From: Nicolas Petton <nicolas@petton.fr>
To: Michael Heerdegen <michael_heerdegen@web.de>,
Sho Takemori <stakemorii@gmail.com>
Cc: 23105@debbugs.gnu.org
Subject: bug#23105: 25.0.92; map-put does not change its argument MAP
Date: Thu, 24 Mar 2016 17:39:30 +0100 [thread overview]
Message-ID: <87fuvfomnx.fsf@petton.fr> (raw)
In-Reply-To: <87y4976f8y.fsf@web.de>
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
Michael Heerdegen <michael_heerdegen@web.de> writes:
> Sho Takemori <stakemorii@gmail.com> writes:
>
>> By expanding map-put, I found that it returns a new list if "m" is a
>> list and the key is not in "m".
>
> Indeed, good catch.
>
> The implementation of `map-put' is wrong: it binds the evaluated place
> expression to a new symbol and uses that symbol as place to operate on.
>
> The intention presumably was to avoid code duplication in the macro
> expansion - which is good - but it fails to change the original place.
Indeed, it is wrong. I will have a look at the issue.
Nico
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2016-03-24 16:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 12:09 bug#23105: 25.0.92; map-put does not change its argument MAP Sho Takemori
2016-03-24 15:57 ` Michael Heerdegen
2016-03-24 16:39 ` Nicolas Petton [this message]
2016-03-24 18:04 ` Nicolas Petton
2016-03-24 18:26 ` Nicolas Petton
[not found] ` <8760waoddm.fsf@petton.fr>
2016-03-25 15:00 ` Sho Takemori
2016-03-25 15:14 ` Nicolas Petton
2016-03-25 15:20 ` Sho Takemori
2016-03-25 17:32 ` Michael Heerdegen
2016-03-25 17:44 ` Michael Heerdegen
2016-03-25 18:45 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuvfomnx.fsf@petton.fr \
--to=nicolas@petton.fr \
--cc=23105@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=stakemorii@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.