From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#24021: FEATURE ADDITION: 25.0.94: goto-marker, jumps to a marker potentially in a different buffer Date: Tue, 19 Jul 2016 21:55:30 -0400 Message-ID: <87fur5cbu5.fsf@users.sourceforge.net> References: <87oa5ucx1a.fsf@users.sourceforge.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1468979788 22347 80.91.229.3 (20 Jul 2016 01:56:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Jul 2016 01:56:28 +0000 (UTC) Cc: rswgnu@gmail.com, 24021@debbugs.gnu.org To: Robert Weiner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 20 03:56:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPgkE-00058R-BX for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jul 2016 03:56:18 +0200 Original-Received: from localhost ([::1]:60027 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPgkA-0004WT-IR for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 21:56:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46074) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPgk4-0004WN-Ea for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 21:56:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPgjy-0002fm-F6 for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 21:56:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPgjy-0002fi-BQ for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 21:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPgjy-0003eR-3R for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 21:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Jul 2016 01:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24021 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24021-submit@debbugs.gnu.org id=B24021.146897973714002 (code B ref 24021); Wed, 20 Jul 2016 01:56:02 +0000 Original-Received: (at 24021) by debbugs.gnu.org; 20 Jul 2016 01:55:37 +0000 Original-Received: from localhost ([127.0.0.1]:57747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPgjZ-0003dm-80 for submit@debbugs.gnu.org; Tue, 19 Jul 2016 21:55:37 -0400 Original-Received: from mail-it0-f50.google.com ([209.85.214.50]:36285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPgjY-0003db-1Y for 24021@debbugs.gnu.org; Tue, 19 Jul 2016 21:55:36 -0400 Original-Received: by mail-it0-f50.google.com with SMTP id f6so105153071ith.1 for <24021@debbugs.gnu.org>; Tue, 19 Jul 2016 18:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=1nGVB4NoeCj4ZQ5odYjQkPxDPBHOCa1gslHdMYLcto4=; b=T0Vk2QhDlubz4EDfwwHim450S+RUzR7lTgGVnNciFoTEBPcrgQ4a5tVv3S4j5kaQdX v/qv/j7tueIFBNP5VTSxEJ5wdjaaH1Jw1MKpOx6NJ0zk0VxKxOF4Mol+Pb4dkoxa4W9j nbbmzP+SC068NxoZDHnTnQ7Lr5KnhqY7SS6LDqgSSVkKOk+82lnOvzndTpiIG0/6cY2z skk0n6u/2vVJYgB7vMMH/9WONOPa4BM7H0i++u7Yqq0xeSNFrs+MwvYezASnmMeT1uzl pZpdBzns4auzh5aR1CToylE1HhidGWZyS/cuNA4bU3SzPTzJOtTqeD7wfZsM73nDDU2R sklw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=1nGVB4NoeCj4ZQ5odYjQkPxDPBHOCa1gslHdMYLcto4=; b=f1dSdQQDFeLSpvS55mzmS6wiDMspnI/AX2p735IiSJpdPpZd8Q/Z1GQv2vcUiIHGbv 6C3G9ScXQe+hunA+M/vPE5OgqhUxlfPn0Cx52A+NbbHulBhcbZ3F5cwivdHSpjYzqr0W ovvdAhaS8xvzgZSI0UyFf0Bao01S4s1ZhsC2OFXguCW9t0jq1Oa15RiSh9V7oaGbbNM5 k7jP+fUzhGFScY21DjOxI/WvK/adeQPbtkMaqjFnqIj6VdS4ett0tUtsLR1wS1n0Cmfw Tec8tvKOIqkAGMFOreOzHjN5Hin1s6fTAY2pk3v+9Re4aXzYehDUUXpa3VGNAYir8D1j gyBg== X-Gm-Message-State: ALyK8tJxt7Sb+BH32WVDXTW7z+tty7OCZwLDn0/nU7H4l9/x2QlKYo/ekPX7Ebwy0wXLpA== X-Received: by 10.36.29.5 with SMTP id 5mr6893667itj.97.1468979730456; Tue, 19 Jul 2016 18:55:30 -0700 (PDT) Original-Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id f9sm349059ioi.2.2016.07.19.18.55.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jul 2016 18:55:29 -0700 (PDT) In-Reply-To: (Robert Weiner's message of "Tue, 19 Jul 2016 09:15:49 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121283 Archived-At: Robert Weiner writes: > > I like these checks as they make the specific error very > clear. set-buffer will trigger a type error when given a nil buffer > but neither marker-buffer nor marker-position signal an error when > given a marker that doesn't point anywhere, so the checks prior to > calling those functions are relevant. Fair enough, I would suggest using (unless ... (error ...)) to avoid having the error checking add nesting depth to the main code. >> >> If this is just a "simple function" (not an interactive command), it >> shouldn't widen, or call switch-to-buffer. >> >> >> >> save-excursion or save-current-buffer don't counteract >> switch-to-buffer, because it affects the UI selected buffer. > > You are right that save-excursion and save-restriction won't > counteract the effects of this function, so its purpose must be to put > the selected window's point at the location of the marker. Possibly, a > macro called with-marker-location could be useful when one needs to > temporarily set buffer and point from a marker and evaluate some forms > but not affect the display. It really just makes more sense to let the caller do (switch-to-buffer (current-buffer)) if needed. Or display-buffer, or pop-to-buffer. Not hard coding the switch-to-buffer call makes the function more flexible and usable in more situations.