From: npostavs@users.sourceforge.net
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 24359@debbugs.gnu.org
Subject: bug#24359: Patch for byte compilation bugs
Date: Sun, 11 Sep 2016 12:36:30 -0400 [thread overview]
Message-ID: <87fup61jht.fsf@users.sourceforge.net> (raw)
In-Reply-To: <CAArVCkT3GKbdx=zLrK1N+EWaLBNsiKwphLKqhNdDv7B+LUoThQ@mail.gmail.com> (Philipp Stephani's message of "Sun, 11 Sep 2016 16:05:27 +0000")
Philipp Stephani <p.stephani2@gmail.com> writes:
> Philipp Stephani <p.stephani2@gmail.com> writes:
> >
> > * lisp/emacs-lisp/macroexp.el (macroexp--funcall-if-compiled)
> > (macroexp--warn-and-return): Use ‘byte-compile-warn’ instead of
> > ‘byte-compile-log-warning’.
> >
> > * lisp/emacs-lisp/bytecomp.el (byte-compile-form, byte-compile-unfold-bcf)
> > (byte-compile-setq, byte-compile-funcall): Use
> > ‘byte-compile-report-error’ instead of ‘byte-compile-log-warning’.
> [...]
> > * lisp/emacs-lisp/cconv.el (cconv-convert, cconv--analyze-use)
> > (cconv--analyze-function, cconv-analyze-form): Use
> > ‘byte-compile-warn’ instead of ‘byte-compile-log-warning’.
> >
> > * lisp/emacs-lisp/byte-opt.el (byte-compile-inline-expand): Use
> > ‘byte-compile-warn’ instead of ‘byte-compile-log-warning’.
> >
> > * lisp/subr.el (add-to-list): Use ‘byte-compile-report-error’ instead
> > of ‘byte-compile-log-warning’.
> > (do-after-load-evaluation): Use ‘byte-compile-warn’ instead of
> > ‘byte-compile-log-warning’.
>
> I think you can combine all these into one entry.
>
> I wouldn't know how, as they are for different files, and AFAIK the changelog format doesn't allow combining messages across files.
Just put them together like entries in the same file, e.g.
* lisp/emacs-lisp/macroexp.el (macroexp--funcall-if-compiled)
(macroexp--warn-and-return):
* lisp/emacs-lisp/bytecomp.el (byte-compile-form, byte-compile-unfold-bcf)
(byte-compile-setq, byte-compile-funcall): Use
‘byte-compile-report-error’ and ‘byte-compile-warn’ instead of
‘byte-compile-log-warning’.
Another example is in 6acff252:
* src/window.c (window_scroll_pixel_based):
* src/xdisp.c (pos_visible_p): Don't allow simulated redisplay to
start outside the accessible portion of the buffer. This avoids
assertion violations when some Lisp narrows the buffer to less
than the current window, and then attempts to scroll the buffer.
next prev parent reply other threads:[~2016-09-11 16:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 17:28 bug#24359: 25.1; batch-byte-compile exits with code 0 even if errors occurred Philipp
[not found] ` <handler.24359.B.147292373921430.ack@debbugs.gnu.org>
2016-09-03 18:45 ` bug#24360: Patch for byte compilation bugs Philipp Stephani
2016-09-04 7:33 ` bug#24359: " martin rudalics
2016-09-04 8:45 ` bug#24360: " Andreas Schwab
2016-09-04 9:34 ` martin rudalics
2016-09-04 8:56 ` Philipp Stephani
2016-09-04 9:35 ` martin rudalics
2016-09-04 10:40 ` Andreas Schwab
2016-09-04 11:22 ` martin rudalics
2016-09-04 21:07 ` bug#24359: " npostavs
2016-09-11 16:05 ` Philipp Stephani
2016-09-11 16:36 ` npostavs [this message]
2016-10-08 23:53 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fup61jht.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=24359@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.