From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore Date: Sat, 24 Dec 2016 10:34:50 -0500 Message-ID: <87fuld9w85.fsf@users.sourceforge.net> References: <8760mr26dr.fsf@openmailbox.org> <87eg13b4jk.fsf@users.sourceforge.net> <878tr9c4bn.fsf@users.sourceforge.net> <8760mcbta2.fsf@users.sourceforge.net> <87tw9va4uu.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1482593659 19532 195.159.176.226 (24 Dec 2016 15:34:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 24 Dec 2016 15:34:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: Mark Karpov , 25157@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Dec 24 16:34:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKoKl-0003jz-L8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Dec 2016 16:34:07 +0100 Original-Received: from localhost ([::1]:43935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKoKq-0001Ru-DL for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Dec 2016 10:34:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKoKj-0001RC-Rb for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 10:34:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKoKf-0001Ni-T4 for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 10:34:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38484) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cKoKf-0001Nc-Ox for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 10:34:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cKoKf-0006wb-Ib for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2016 10:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Dec 2016 15:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 25157-submit@debbugs.gnu.org id=B25157.148259363426678 (code B ref 25157); Sat, 24 Dec 2016 15:34:01 +0000 Original-Received: (at 25157) by debbugs.gnu.org; 24 Dec 2016 15:33:54 +0000 Original-Received: from localhost ([127.0.0.1]:53883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKoKY-0006w9-L9 for submit@debbugs.gnu.org; Sat, 24 Dec 2016 10:33:54 -0500 Original-Received: from mail-it0-f67.google.com ([209.85.214.67]:33170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKoKW-0006vr-Il; Sat, 24 Dec 2016 10:33:53 -0500 Original-Received: by mail-it0-f67.google.com with SMTP id c20so27146874itb.0; Sat, 24 Dec 2016 07:33:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=wdOGP3PMK6GD823KIl9HL8GvTT/25aBBhTYU3mobtyo=; b=rW4OGx2JEitGEv78pjrPVoGyMrX8Hmg7+stXMATbEY3yD/vJvqzfXpaRRAfwRKnWvN rSXY4p2OZn5QxrX15RHUpHTG3lcwmZhmyuCaY8mPdspzueLSumFYrL9J1td2rjdcFuOE QBX6R1LKDYI/47AD5AsK+nlN0TBvoju9Wmfaap3ktJMNhQM54Ioh14tC6sn0q0xaQ2aQ j/356C6344nD4TWdgg1yrGkdXo/tGNWm9z/3/GhMHbj+d9Gs0dYcfMtqqk14S1M5MPk/ TACIOvUH3oVAxwVOSTOGR9Q7tOUC+atDRC88STrkvrWHQgdNX1n+isr9owqYQJ16v/A8 QPfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=wdOGP3PMK6GD823KIl9HL8GvTT/25aBBhTYU3mobtyo=; b=DfxIlQa/EpcISgZoNo4Z1PjwhC3GKM7Gp3f7EEHhDXzDFKNBJN7yYkLNc1K2Vtdr4b abvpxnBFw+Vs54yLysi8GbPAkIyJqNoFSHYobkveur0+V7bFtaBoBzcw3HC8XLgq8ClQ WHLFv8AiavkcQNtS2BnShLOoB9hcHII4YGp5x79s1XzUtgul0iZpJPRsPlFfFoGyBv/z vCqSxtinYKnUZknOYy6AZ+Epqr8tfiWKCTUnWiSJ9cyUFH20gDNtPMD+vM7gFIP9X/Lw n9d/cKd2svz2UQXt2CB8Hp9jsh05ww6zLKHVQ2MmCV3RcEbJma3bkhifZG1uUL18Ho7F APbQ== X-Gm-Message-State: AIkVDXIbywvcjwDWSf9BUmo1cHhnTa7AWEfanStZcNAK5ULOZrH7NR/5WZxOvEIrf++0PQ== X-Received: by 10.36.105.14 with SMTP id e14mr19359694itc.115.1482593627090; Sat, 24 Dec 2016 07:33:47 -0800 (PST) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id e143sm16283780itc.9.2016.12.24.07.33.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 24 Dec 2016 07:33:46 -0800 (PST) In-Reply-To: (Reuben Thomas's message of "Fri, 23 Dec 2016 10:44:54 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127399 Archived-At: tags 25157 fixed close 25157 26.1 quit Reuben Thomas writes: > >> > >> (whitespace-cleanup): Remove a FIXME: the reason for save-match-data > >> is the call of re-search-forward. > >> > >> I'm not sure this is a sufficient explanation of why save-match-data = is > >> needed. Usually in Emacs the caller is responsible for saving the mat= ch > >> data, if it needs to. I don't really see the need here. > > > > Can it be removed then? > > Probably yes. > > =E2=80=8BGreat; can you then install a suitable patch, please? I've pushed the first patch as cf5417f02887 "Fix whitespace eob cleanup", removed save-match-data in da52e939aa26 "Remove redundant `save-match-data' in whitespace.el".