From: npostavs@users.sourceforge.net
To: Reuben Thomas <rrt@sc3d.org>
Cc: Mark Karpov <markkarpov@openmailbox.org>, 25157@debbugs.gnu.org
Subject: bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore
Date: Sat, 24 Dec 2016 10:34:50 -0500 [thread overview]
Message-ID: <87fuld9w85.fsf@users.sourceforge.net> (raw)
In-Reply-To: <CAOnWdoigPwwFF4AUMV4cBtj5Z7SQm7F7tsybC1=9-WN41JtgmA@mail.gmail.com> (Reuben Thomas's message of "Fri, 23 Dec 2016 10:44:54 +0000")
tags 25157 fixed
close 25157 26.1
quit
Reuben Thomas <rrt@sc3d.org> writes:
> >>
> >> (whitespace-cleanup): Remove a FIXME: the reason for save-match-data
> >> is the call of re-search-forward.
> >>
> >> I'm not sure this is a sufficient explanation of why save-match-data is
> >> needed. Usually in Emacs the caller is responsible for saving the match
> >> data, if it needs to. I don't really see the need here.
> >
> > Can it be removed then?
>
> Probably yes.
>
> Great; can you then install a suitable patch, please?
I've pushed the first patch as cf5417f02887 "Fix whitespace eob
cleanup", removed save-match-data in da52e939aa26 "Remove redundant
`save-match-data' in whitespace.el".
next prev parent reply other threads:[~2016-12-24 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 14:41 bug#25157: 26.0.50; whitespace-cleanup does not remove single trailing empty line anymore Mark Karpov
2016-12-20 4:36 ` npostavs
2016-12-20 18:37 ` Reuben Thomas
2016-12-21 0:51 ` Reuben Thomas
2016-12-21 4:07 ` npostavs
2016-12-21 11:07 ` Reuben Thomas
2016-12-22 2:18 ` npostavs
2016-12-22 12:53 ` Reuben Thomas
2016-12-23 0:03 ` npostavs
2016-12-23 10:44 ` Reuben Thomas
2016-12-24 15:34 ` npostavs [this message]
2016-12-26 22:37 ` Reuben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuld9w85.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=25157@debbugs.gnu.org \
--cc=markkarpov@openmailbox.org \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.