From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 39d163a: load-dir: fix CL and free variable warnings Date: Mon, 20 Mar 2017 10:00:44 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87fui89hf7.fsf@lifelogs.com> References: <20170320125824.26461.58778@vcs0.savannah.gnu.org> <20170320125825.4C92420E17@vcs0.savannah.gnu.org> <87pohc9iz3.fsf@lifelogs.com> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490018514 28883 195.159.176.226 (20 Mar 2017 14:01:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Mar 2017 14:01:54 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 20 15:01:42 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cpxsQ-0006Fb-3X for ged-emacs-devel@m.gmane.org; Mon, 20 Mar 2017 15:01:38 +0100 Original-Received: from localhost ([::1]:33170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpxsW-0007TU-2m for ged-emacs-devel@m.gmane.org; Mon, 20 Mar 2017 10:01:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cpxrs-0007SB-Mj for emacs-devel@gnu.org; Mon, 20 Mar 2017 10:01:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cpxro-00044C-Fv for emacs-devel@gnu.org; Mon, 20 Mar 2017 10:01:04 -0400 Original-Received: from [195.159.176.226] (port=35554 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cpxro-00043U-2C for emacs-devel@gnu.org; Mon, 20 Mar 2017 10:01:00 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cpxrX-0002Ja-JR for emacs-devel@gnu.org; Mon, 20 Mar 2017 15:00:43 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 37 Original-X-Complaints-To: usenet@blaine.gmane.org X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:I/RdE4QG+Yh4iExYb7pBWrdHtaI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213182 Archived-At: On Mon, 20 Mar 2017 09:51:07 -0400 Stefan Monnier wrote: SM> Either use `some` instead of `cl-some`, or use `cl-lib` (and add SM> a corresponding `Package-Requires: ((cl-lib "0.5"))` in the file's SM> header). BTW, I noticed ELPAs' lmc/lmc.el has "Package-Requires" without the ":" afterwards. SM> Stefan "who favors the `cl-lib` solution" Like this? I'll commit if you agree. Thanks for the help Ted diff --git a/packages/load-dir/load-dir.el b/packages/load-dir/load-dir.el index ab88ea7..b2231a5 100644 --- a/packages/load-dir/load-dir.el +++ b/packages/load-dir/load-dir.el @@ -9,6 +9,7 @@ ;; Maintainer: Teodor Zlatanov ;; Version: 0.0.5 ;; Keywords: lisp, files, convenience +;; Package-Requires: ((cl-lib "0.5")) ;; This file is part of GNU Emacs. @@ -43,7 +44,7 @@ ;;; Code: -(eval-when-compile (require 'cl-extra)) +(eval-when-compile (require 'cl-lib)) (defgroup load-dir nil "Automatically load all Emacs Lisp files in given directories."