From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#26628: [PATCH] Fix memory leak of cwd string in emacsclient Date: Wed, 31 May 2017 22:59:49 -0400 Message-ID: <87fufk2z16.fsf@users.sourceforge.net> References: <87zif6dur5.fsf@linux-m68k.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1496285954 10194 195.159.176.226 (1 Jun 2017 02:59:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 1 Jun 2017 02:59:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: Anders Waldenborg , 26628@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 01 04:59:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGGKK-0002P4-03 for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Jun 2017 04:59:08 +0200 Original-Received: from localhost ([::1]:35007 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGGKP-0003l3-D0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 May 2017 22:59:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37464) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dGGKH-0003jb-QU for bug-gnu-emacs@gnu.org; Wed, 31 May 2017 22:59:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dGGKE-0000Xi-PZ for bug-gnu-emacs@gnu.org; Wed, 31 May 2017 22:59:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45563) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dGGKE-0000XF-Ln for bug-gnu-emacs@gnu.org; Wed, 31 May 2017 22:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dGGKE-0007QS-5b for bug-gnu-emacs@gnu.org; Wed, 31 May 2017 22:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jun 2017 02:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 26628-submit@debbugs.gnu.org id=B26628.149628590228496 (code B ref 26628); Thu, 01 Jun 2017 02:59:02 +0000 Original-Received: (at 26628) by debbugs.gnu.org; 1 Jun 2017 02:58:22 +0000 Original-Received: from localhost ([127.0.0.1]:48240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGGJZ-0007PT-NC for submit@debbugs.gnu.org; Wed, 31 May 2017 22:58:21 -0400 Original-Received: from mail-io0-f172.google.com ([209.85.223.172]:34972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGGJW-0007PA-Si; Wed, 31 May 2017 22:58:19 -0400 Original-Received: by mail-io0-f172.google.com with SMTP id f102so25521659ioi.2; Wed, 31 May 2017 19:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=I1oPVBQJUcEz+WNyTs/aBvYee115UGscY9EmHHR0D9I=; b=PFKdoJ5pPUji2TrNS9PEaMwpa+0SBjeAvxvCZZPXPNlugUmAAwrVZvbU+o+NQzVPYK ooTKs0CENuN8q9/w34KrohKasnzGLIyuLYMte38zF6+cpGxj54oyE5IJj0U+SbKbWYlb ZfuMbxLIORPhPItNK5+fHpEkThHw/X+v0zeO3RU1GwAJDKkjYZVp8t0y/fEOgRJTS2Vr 5O9Ji1nzsh6i2gUdPYqf6ESbOYDyp5PHUoShl7JZKQW6+LIXB9lq08d95qZxJLiU9V6o +l6fcYk8IDw+/lYTFXWS3MTZgFdcrABuLMQfi74iJh61HCh0uwBLPxbxCajUGSnkvjc7 2X5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=I1oPVBQJUcEz+WNyTs/aBvYee115UGscY9EmHHR0D9I=; b=iNKnxEp8jQyxLZlk5ANo2MxSP0bqJgItJXxm4rm+IGbI5NA4hxwn6IMI+BE19x9Fo4 aNTKZiJ6waiBPnH4w7bXKylMBOYTE4HiZApuR7Q4rsl2yWBaCp+SOUCVXq2tEshd0GXi 8sE2ZSVYlXZs1vBnqU4QcYa+jWCO24FtnOdjtlhYbB+sBSSbKdvF15OY1q0FF89BiYT6 roqlrG4FTu9afxPXmjlVy4k1E03kuWts3zAF68C5aeroFHq5Dz16rqRgqd7EIrs3iUwb T8JRQ2MgHzw2u2e7G1rmVaVxE5QCrqsn8Z1ypA3pwRf/JPQ4vLHLxBcjY+rur2mVC4QQ Pd0Q== X-Gm-Message-State: AODbwcA2Rq+5rD5W67X2qO9C3VYDMKvBjbsL1FxwodjMq86qkGNcAYba hoJdxLNdXO1XBTGs X-Received: by 10.107.28.70 with SMTP id c67mr25338012ioc.142.1496285892991; Wed, 31 May 2017 19:58:12 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id g198sm11880355itb.29.2017.05.31.19.58.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 May 2017 19:58:11 -0700 (PDT) In-Reply-To: <87zif6dur5.fsf@linux-m68k.org> (Andreas Schwab's message of "Mon, 24 Apr 2017 11:23:26 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133124 Archived-At: tags 26628 fixed close 26628 26.1 quit Andreas Schwab writes: > On Apr 23 2017, Anders Waldenborg wrote: > >> * lib-src/emacsclient.c (main): emacsclient retrieves the current >> working directory using get_current_dir_name which returns a newly >> allocated string. Make sure this string is freed before exiting. > > There is no need to free it since the process exists right away anyway. On the other hand, it doesn't really hurt to free it either, pushed to master [1: c221f1466e]. [1: c221f1466e]: 2017-05-31 22:58:30 -0400 Fix memory leak of cwd string in emacsclient (Bug#26628) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c221f1466ed7e0f11f142d9cb3c0247b10e511c6