all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Anders Waldenborg <anders@0x63.nu>, 26628@debbugs.gnu.org
Subject: bug#26628: [PATCH] Fix memory leak of cwd string in emacsclient
Date: Wed, 31 May 2017 22:59:49 -0400	[thread overview]
Message-ID: <87fufk2z16.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87zif6dur5.fsf@linux-m68k.org> (Andreas Schwab's message of "Mon, 24 Apr 2017 11:23:26 +0200")

tags 26628 fixed
close 26628 26.1
quit

Andreas Schwab <schwab@linux-m68k.org> writes:

> On Apr 23 2017, Anders Waldenborg <anders@0x63.nu> wrote:
>
>> * lib-src/emacsclient.c (main): emacsclient retrieves the current
>>   working directory using get_current_dir_name which returns a newly
>>   allocated string. Make sure this string is freed before exiting.
>
> There is no need to free it since the process exists right away anyway.

On the other hand, it doesn't really hurt to free it either, pushed to
master [1: c221f1466e].

[1: c221f1466e]: 2017-05-31 22:58:30 -0400
  Fix memory leak of cwd string in emacsclient (Bug#26628)
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c221f1466ed7e0f11f142d9cb3c0247b10e511c6





  parent reply	other threads:[~2017-06-01  2:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-23 19:23 bug#26628: [PATCH] Fix memory leak of cwd string in emacsclient Anders Waldenborg
2017-04-24  9:23 ` Andreas Schwab
2017-04-24 16:05   ` Anders Waldenborg
2017-06-01  2:59   ` npostavs [this message]
2017-06-01  6:30 ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fufk2z16.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=26628@debbugs.gnu.org \
    --cc=anders@0x63.nu \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.