From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Trying out GitLab (was Re: In support of Jonas Bernoulli's Magit) Date: Sat, 08 Jul 2017 22:02:44 +0100 Message-ID: <87fue68wwb.fsf@russet.org.uk> References: <87poddqb5y.fsf@gnu.org> <871spsveyw.fsf@petton.fr> <87van4tzu9.fsf@petton.fr> <871spsla9r.fsf@lifelogs.com> <871sprb394.fsf@gmail.com> <640b51d5-9786-358c-985e-c55023acd75c@yandex.ru> <838tjzkuvs.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1499547781 756 195.159.176.226 (8 Jul 2017 21:03:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Jul 2017 21:03:01 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) Cc: tzz@lifelogs.com, Eli Zaretskii , avarab@gmail.com, toon@iotcl.com, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 08 23:02:57 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTwsQ-00089K-G4 for ged-emacs-devel@m.gmane.org; Sat, 08 Jul 2017 23:02:54 +0200 Original-Received: from localhost ([::1]:34047 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTwsU-000162-GG for ged-emacs-devel@m.gmane.org; Sat, 08 Jul 2017 17:02:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTwsN-00015k-Gu for emacs-devel@gnu.org; Sat, 08 Jul 2017 17:02:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTwsM-0007Pu-NM for emacs-devel@gnu.org; Sat, 08 Jul 2017 17:02:51 -0400 Original-Received: from cloud103.planethippo.com ([78.129.138.110]:41712) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dTwsI-0007Om-PM; Sat, 08 Jul 2017 17:02:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=dsoiHo4bWygUn87t3LXdRiqbmNH05CA/Gw50qOlWY+Q=; b=pFc7IP+1eAWLrFQgv0IgGZwJI GEZrzaYDJ3/2u8kFeDuDbpY981CWN79z/T6havlI3cMod9/Mw0KWgog4m0TelxV9/kDv4pFyDT1Ui 5xT0E7iOgzhcLX1SsaWBO1+QFjNwAPVfiAOoCSvqqYS+N1Nuu8ZviHmoZPegXBYKlFu9D9eAwy+My Q6doV611oWLKue7J2X9kth2nAGMNBfP7ctifNUIdmHyLv6rKy7eOFdILFeo+40jAqzUnbpicRFJA8 sMs2E86cL3FRr4NJGoPTuM067vjC9XScHv4oUYmXdLUFXo+z1j9rePLoztuCuMCOFLmtd94lu8uln 7Nks59XQg==; Original-Received: from cpc8-benw10-2-0-cust100.16-2.cable.virginm.net ([92.233.204.101]:55338 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89) (envelope-from ) id 1dTwsH-000CMI-B0; Sat, 08 Jul 2017 21:02:45 +0000 In-Reply-To: (Dmitry Gutov's message of "Sat, 8 Jul 2017 15:04:22 +0300") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-Source: X-Source-Args: X-Source-Dir: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 78.129.138.110 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216342 Archived-At: Dmitry Gutov writes: > On 7/8/17 2:53 PM, Eli Zaretskii wrote: > >> It's actually more than that: patches submitted to Emacs need to >> conform to our coding and various other standards: include >> properly-formatted commit log messages, documentation, and (where >> appropriate) tests, etc. Patch review could require cleanup changes >> etc. > > That doesn't negate the advantages of integrated solutions like > GitLab, though. Emacs is not the only project with standards. > > We often enforce those via code review, and GitLab helps with that. And the process is much easier in most projects. Push to feature branch, get comments, using line-level in diff commenting. Then fix, squash, force push. Finally, single click merge, PR closes. Phil