From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Newsgroups: gmane.emacs.bugs Subject: bug#28814: [BUMP, PATCH] (26.0.90; When *xref* window is needed, original window-switching intent is lost ) Date: Wed, 25 Oct 2017 16:35:10 +0100 Message-ID: <87fua7s0k1.fsf@gmail.com> References: <87infjm3p3.fsf@gmail.com> <871slyi3lk.fsf_-_@gmail.com> <87lgk22ryu.fsf@gmail.com> <87fua91vis.fsf@gmail.com> <13af136e-12fb-4e8d-81ff-63424b1e1943@yandex.ru> <87y3nzu0xu.fsf@gmail.com> <4b46c989-f94e-a5ce-9264-069c34096419@yandex.ru> <87o9ovs6d2.fsf@gmail.com> <99a495f7-0d27-27b1-e540-603900d7b614@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1508945793 10079 195.159.176.226 (25 Oct 2017 15:36:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 25 Oct 2017 15:36:33 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: 28814@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 25 17:36:21 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7Nj4-0000df-QF for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Oct 2017 17:36:15 +0200 Original-Received: from localhost ([::1]:48820 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7NjA-0004Gx-Ao for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Oct 2017 11:36:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e7Niy-0004FI-3s for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 11:36:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e7Niu-00075y-0A for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 11:36:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53053) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e7Nit-00075Z-Py for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 11:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e7Nis-0003JY-Ak for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2017 11:36:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: joaotavora@gmail.com (=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?=) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Oct 2017 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28814 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28814-submit@debbugs.gnu.org id=B28814.150894572112686 (code B ref 28814); Wed, 25 Oct 2017 15:36:02 +0000 Original-Received: (at 28814) by debbugs.gnu.org; 25 Oct 2017 15:35:21 +0000 Original-Received: from localhost ([127.0.0.1]:33501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7NiC-0003IY-LT for submit@debbugs.gnu.org; Wed, 25 Oct 2017 11:35:20 -0400 Original-Received: from mail-wm0-f51.google.com ([74.125.82.51]:48642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e7NiB-0003IL-OU for 28814@debbugs.gnu.org; Wed, 25 Oct 2017 11:35:20 -0400 Original-Received: by mail-wm0-f51.google.com with SMTP id p75so2680494wmg.3 for <28814@debbugs.gnu.org>; Wed, 25 Oct 2017 08:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=oGEzQMxs5odELiv1+//9/oKnQNDo9CFA6rwcNZfyO4o=; b=NRZFVK0bTjJ94Sf4K0QXhOpcUSVuOxW6Xu6vsOMrM49kGzljMI3GM/UCV/NDT95J8x q/ZX5YFaAhNrixuViIH9xCOaE0s4/H88Mh0x2Kqe7eoq/BiEECxX75PzGY8T0pslh1BJ Ua8oh/2ldBFT+ah/EoawGSWLmfMa/rPd9SYjlCgllMaXJJvNkob2FnNNtg51ITvNo4l6 5dM9kfZjknyzd9wwZ53iDsMY7js2LApnWAZcVuEfLvopJ5hzKF/ewthqbhwbk1vMqCJ5 jf/eM2IB3XxhdXyH2CWKToZ/SfZzovgxw0/FiR7A5GJGnLJqgZeZpuKeA3kiR13NRGVn DEdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=oGEzQMxs5odELiv1+//9/oKnQNDo9CFA6rwcNZfyO4o=; b=ROjs6sDG5AupWF8Oxhx1NS8jm6Sd9aeOjdnElaoRM3GmIZH6W/rJFkhINOTPo4bmGp rhWG22ceXNR4xPs1C2Tisq/Cm7IgM3fwtewCiINt6st3Ysx3ML0hd4hXEcjiHobieSMV V9BTMpWu9oZQJlHPZm6197sZ0sJs4nI0ey3s5UIoGaawpJXaVxu8Ew3IR+hIhA8U59oa ESCLIj5t9rQdPuykgpg/TpaqrTUlHXGbi3KYIDC2CuR7IPPvF7AB1BMGr9a8KRwfG/Cv O1NvXKuGNhXWJruSbzJLlY/3pPi8m9ZKrQsFLsOMVnHMcSZo2ZiJ6T4Fye/JANFisXgW wwXg== X-Gm-Message-State: AMCzsaVPExMMihzmbHeKctHzTMfJTNVqiJhGXALVxJiNGcxxmUNbxi74 Tni0Po9aYthMdKIldsMRnjy33zVI X-Google-Smtp-Source: ABhQp+RhDK0iJB6Q0R9GU8n6GKTm+A4umIA0P6R1HB3EhOvlAgfquTlxW9fNCkSDtv2EpyPJGmaARQ== X-Received: by 10.28.55.78 with SMTP id e75mr2046819wma.112.1508945713819; Wed, 25 Oct 2017 08:35:13 -0700 (PDT) Original-Received: from lolita.yourcompany.com ([88.157.205.17]) by smtp.gmail.com with ESMTPSA id u8sm3528960wmd.33.2017.10.25.08.35.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Oct 2017 08:35:13 -0700 (PDT) In-Reply-To: <99a495f7-0d27-27b1-e540-603900d7b614@yandex.ru> (Dmitry Gutov's message of "Wed, 25 Oct 2017 17:49:09 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138968 Archived-At: Dmitry Gutov writes: > On 10/25/17 4:29 PM, Jo=C3=A3o T=C3=A1vora wrote: > But the window configuration changes that happen while the user > selects the destination in the xref buffer, can't be undone with > 'quit', with out without your patches. You=E2=80=99re right, my patches they keep the window configuration for some definition of "keep" :-). However, a much more correct definition of "keep" than the one we have now. >> If that UI can be improved, it certainly should. (I have some very old >> ideas about a single window dedicated frame for help windows that could >> be discussed and developed). But whatever is done it should be done to >> Emacs as a whole, to preserve consistency. > > If you're talking about window management in general, that seems > orthogonal to me. As it should be. But if we give xref.el a special interface it ceases to be :-) > Let's wait for Eli's opinion. It seems Eli=E2=80=99s OK with the current behaviour minus the C-u RET. > The binding I have in mind is in dired-mode. There, 'a' replaces the > current buffer with another. > > I don't recall any other 'a' bindings, off the top of my head. Then perhaps =E2=80=99a=E2=80=99 can be xref-quit-and-goto-xref if you=E2= =80=99re not opposed to that. > SPC is not bound by default. And you'll probably use 'n' in > xref-find-definitions output as well. You=E2=80=99re right. SPC should be bound to xref-show-xref though, if we a= re honour the SLIME ancestry. >> When I find the one >> I want to edit, I press "RET". I=E2=80=99m a big boy, I can find the *xr= ef* >> buffer again :-) > > Would you prefer similar behavior in *Grep* buffers as well? If you > still use those. Meh... Maybe. I don=E2=80=99t know. I would prefer to always use XREF and project-find-regexp (that I just learned about, thanks!), if only that could be enhanced to the much much faster =E2=80=98git grep=E2=80=99 in Git= projects. Perhaps we could work on that as a separate modification.