From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#18951: eshell-pcomplete removes asterisk when attempting completion Date: Sun, 05 Nov 2017 12:17:27 -0500 Message-ID: <87fu9s7ihk.fsf@users.sourceforge.net> References: <86tx2ei4b4.fsf@yandex.ru> <871slid45i.fsf@kraus.my> <87efpi9neq.fsf@users.sourceforge.net> <877ev9p3m7.fsf@kraus.my> <87po909arm.fsf@users.sourceforge.net> <8760assr52.fsf@kraus.my> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1509902291 20081 195.159.176.226 (5 Nov 2017 17:18:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Nov 2017 17:18:11 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: Daniel Kraus , 18951@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 05 18:18:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBOYg-00055m-LC for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Nov 2017 18:18:06 +0100 Original-Received: from localhost ([::1]:45102 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBOYo-0007eu-4A for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Nov 2017 12:18:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eBOYh-0007ed-2Q for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 12:18:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eBOYc-00076B-Qp for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 12:18:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43811) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eBOYc-00075s-NN for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 12:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eBOYc-0006Ed-Al for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2017 12:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Nov 2017 17:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18951 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18951-submit@debbugs.gnu.org id=B18951.150990225723934 (code B ref 18951); Sun, 05 Nov 2017 17:18:02 +0000 Original-Received: (at 18951) by debbugs.gnu.org; 5 Nov 2017 17:17:37 +0000 Original-Received: from localhost ([127.0.0.1]:52492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBOYD-0006Ds-Hg for submit@debbugs.gnu.org; Sun, 05 Nov 2017 12:17:37 -0500 Original-Received: from mail-io0-f181.google.com ([209.85.223.181]:50326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eBOYC-0006DW-1n; Sun, 05 Nov 2017 12:17:36 -0500 Original-Received: by mail-io0-f181.google.com with SMTP id 97so13354702iok.7; Sun, 05 Nov 2017 09:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=/2sS6xfRua++iCx2pNW4tPI07sH/i+1d6FmLYf1/GLE=; b=FFxwEyIuXtoOrZZn2Sj1Kc4O9DnzsrrGA5Cd6GgYeRHJJsBQNBY3bf/DySOUFShD4C CAq1ajyvStS1yv8MiRKlSWzoX+wX5VKbwDG+og99eRXGiZUvtj+nB20dQh3+hu0LkF1t AW7cSYL9CQa2FdhunCWLugOzlTS2cWjJhQMWgLwP3y3PNc0+AkdTlCvQssSxmcpAepPo oJHUHzleIKpBDOeCCEu5+Z4fe6JppTNExpQ1h76SyTzldJjiEdnaGSkx8QVplUaX6fw5 lQL1CslBZfUE90RGQ17AkR0XWN5ML7OCZjc41OG5vy+X/s9EhkivSWLAxjp5mv/OmEIP MWTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=/2sS6xfRua++iCx2pNW4tPI07sH/i+1d6FmLYf1/GLE=; b=FFHQy7iI5AflelEhQ/VN7desZ6pT4EK7A07QDzZluh1lr+/tVh2WmDuspdJCD82jgA eFc11EErnx6obnu0sjZmvRkkMoAVjjrg/CQk8VlYVPr3zh/z9xz+6Gw7GLqohPQx7snO 4ncHOk2B7tWaO65YnLnY32MYQP35/XP/HHYCWwxc9k6FP9EjdJfEVImFQAbqdsaj151R Xpj+nygjYE8WNGtoWUGzRs/Ob4u+vB7Qd+dv4oqMW+eesxq72YEXc5m0Ps5noNORlGCk e3rH49ODrG+jE8kbUBKWXR9fdaaoyzqfoXeA19Hb+2Hv3/6ZJOLZlFMogGmTzzPc0o9c vOUQ== X-Gm-Message-State: AJaThX6PENtqFfLtfJuDdAZ6/BAxe0pjxKEfv1Ol/CGxfOMEDSjSaYfH xP2S4FxhexkzP/ANiaN5mdps1w== X-Google-Smtp-Source: ABhQp+Qp8a6RNVSt5Hs46d46uxXlTUOae5gzI/sQISOMHMh4LUclOy+z6TiByUWZ5j7jaBH7f4hkwg== X-Received: by 10.107.174.206 with SMTP id n75mr4619588ioo.43.1509902249879; Sun, 05 Nov 2017 09:17:29 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v5sm4665517iog.78.2017.11.05.09.17.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 05 Nov 2017 09:17:28 -0800 (PST) In-Reply-To: (Dmitry Gutov's message of "Fri, 3 Nov 2017 23:25:34 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139474 Archived-At: tags 18951 fixed close 18951 26.1 quit Dmitry Gutov writes: > On 11/2/17 4:15 PM, Daniel Kraus wrote: >>> --- i/lisp/pcomplete.el >>> +++ w/lisp/pcomplete.el >>> @@ -772,7 +772,7 @@ pcomplete-parse-arguments >>> (setq c (cdr c))) >>> (setq pcomplete-stub (substring common-stub 0 len) >>> pcomplete-autolist t) >>> - (when (and begin (not pcomplete-show-list)) >>> + (when (and begin (> len 0) (not pcomplete-show-list)) >>> (delete-region begin (point)) >>> (pcomplete-insert-entry "" pcomplete-stub)) >>> (throw 'pcomplete-completions completions)) >> >> I didn't test it too much if something else breaks but it >> seems to work. pcomplete doesn't remove the * and company >> mode also seems to work without problems now. > > Looking good in my testing, and fixes the problem. Thanks! > pcomplete-completion-at-point is still buggy, of course, but no worse > than before. Okay, pushed to emacs-26. [1: 5d744e032f]: 2017-11-05 11:36:20 -0500 Don't replace user input when completion prefix is empty (Bug#18951) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5d744e032fee9ce60446a3cc0cf7c2e681ace465>