From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#29749: 27.0.50; Fix header value extraction in Gnus registry Date: Mon, 18 Dec 2017 10:12:00 -0800 Message-ID: <87fu87lxcf.fsf@ericabrahamsen.net> References: <87tvwqjfvk.fsf@ericabrahamsen.net> <873748lvoe.fsf@lifelogs.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1513622990 11880 195.159.176.226 (18 Dec 2017 18:49:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 18 Dec 2017 18:49:50 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: 29749@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 18 19:49:46 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eR0Tx-0002kp-SN for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Dec 2017 19:49:46 +0100 Original-Received: from localhost ([::1]:53731 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eR0Vw-0001Am-0F for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Dec 2017 13:51:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQzvV-0001DZ-68 for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2017 13:14:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQzvS-0002kd-A5 for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2017 13:14:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60370) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQzvS-0002jH-7J for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2017 13:14:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eQzvO-0006IS-QS for bug-gnu-emacs@gnu.org; Mon, 18 Dec 2017 13:14:02 -0500 Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Dec 2017 18:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 29749 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 29749@debbugs.gnu.org, eric@ericabrahamsen.net, eric@ericabrahamsen.net Original-Received: via spool by 29749-done@debbugs.gnu.org id=D29749.151362083924165 (code D ref 29749); Mon, 18 Dec 2017 18:14:02 +0000 Original-Received: (at 29749-done) by debbugs.gnu.org; 18 Dec 2017 18:13:59 +0000 Original-Received: from localhost ([127.0.0.1]:40813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQzvL-0006He-B0 for submit@debbugs.gnu.org; Mon, 18 Dec 2017 13:13:59 -0500 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:43417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQzvJ-0006HM-Qx; Mon, 18 Dec 2017 13:13:58 -0500 Original-Received: from localhost (96-89-141-238-static.hfc.comcastbusiness.net [96.89.141.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id BD8F7C019F; Mon, 18 Dec 2017 18:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1513620837; bh=TWrgRNI8DuFW+g5AP1oIjkKAnn7co1txtct0JmAa4sk=; h=From:To:Subject:References:Date:In-Reply-To:From; b=NSioL/4c8CFFZNChPsQUBQTM90IrRK7wfYVM9w866lNdMgrPJQWoDxzXN0jd/zO3h JkbQgRdY21aRp59MHyDzz2RSkfr6+vYZsQB0dj3Qhl0DS+8mthnJLFu6ZZWnkJvLp/ a04+b2Sjj0TWFcMm9wSJyKmVEemxsmAOsRhPXH5c= In-Reply-To: <873748lvoe.fsf@lifelogs.com> (Ted Zlatanov's message of "Sun, 17 Dec 2017 19:35:45 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141226 Archived-At: On 12/17/17 19:35 PM, Ted Zlatanov wrote: > On Sat, 16 Dec 2017 17:35:27 -0800 Eric Abrahamsen wrote: > > EA> The Gnus registry extracts some header values from messages using > EA> `gnus-registry-fetch-header-fast'. There are two problems with this: > > EA> 1. It is called with its arguments reversed which (by luck) causes it to > EA> always return nil. > > EA> 2. If it were called correctly it would raise an error, as it tries to > EA> use `assq' to find a string key in a vector. Maybe `gnus-data-header' > EA> used to return a different value, but so far as I can tell this hasn't > EA> worked for quite some time. > > EA> It's a bug, but it's one that hasn't done much harm for a while, so I'm > EA> proposing this for master. > > Thank you so much for patching that. I'm happy with your fix. No problem! That's pushed.