From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: netsec 682578f 4/6: Add option to bypass NSM TLS checks on local networks Date: Tue, 17 Jul 2018 20:07:30 +0200 Message-ID: <87fu0hg2hp.fsf@gmail.com> References: <20180714170806.8972.58581@vcs0.savannah.gnu.org> <20180714170809.C3A3920456@vcs0.savannah.gnu.org> <87o9f84t89.fsf@gmail.com> <4C758D1D-7C3A-425A-852F-75E03C779E01@gmail.com> <87va9fs3ro.fsf@gmail.com> <8736wis8w3.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531850738 27343 195.159.176.226 (17 Jul 2018 18:05:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Jul 2018 18:05:38 +0000 (UTC) Cc: eggert@cs.ucla.edu To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 17 20:05:34 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffULt-00070O-Ks for ged-emacs-devel@m.gmane.org; Tue, 17 Jul 2018 20:05:33 +0200 Original-Received: from localhost ([::1]:60778 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffUO0-00007t-Hs for ged-emacs-devel@m.gmane.org; Tue, 17 Jul 2018 14:07:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffUNu-00007n-2z for emacs-devel@gnu.org; Tue, 17 Jul 2018 14:07:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffUNq-00020o-1r for emacs-devel@gnu.org; Tue, 17 Jul 2018 14:07:38 -0400 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:38654) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffUNp-000209-Qi for emacs-devel@gnu.org; Tue, 17 Jul 2018 14:07:33 -0400 Original-Received: by mail-wr1-x436.google.com with SMTP id v14-v6so2130568wro.5 for ; Tue, 17 Jul 2018 11:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-followup-to:mail-copies-to :gmane-reply-to-list:date:message-id:mime-version; bh=hQZ62s0+USPY9fC8MiaD0fZgG6GjDB94NKFj4j7mY2k=; b=dMnoSyqPY2zOBQUs0ONnDvQXKBZRCgg/a8KCTv/1eEIk4FwMYMjZ75YJYp8+QUWrXf WhKtXgcoMMoPk1/x0lrhwBMUfPrn6CnaS7kfJxozFMcvbEgpdqNYhvk16RRLZdwKVBVV Hhfq0mF2gqRe5rN3dPqvvWQXZtiVoDQmThyxj4RlN9JRoiwZZ6cDDRH6bdBOazppopgT UNn3NERvjdMneDJvvWfCRm91/gmS7eYoG/u8l1bV6JyRESTWkZAdnuUb0+bAb735Wp8I FzFSGVe31Bmyl1WdwHxEMijlF2uuHI+/gz2PD6Dd8+b6rcRDzXu3xavBsPGdRmtg1bsM zpJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-followup-to :mail-copies-to:gmane-reply-to-list:date:message-id:mime-version; bh=hQZ62s0+USPY9fC8MiaD0fZgG6GjDB94NKFj4j7mY2k=; b=dqqoip1bOkI1xNlg+pQMo5W9dTGKSQIwaQ0pVPlQR6/SS3hi6IjDK5fGZnUBhzqWmf 4oMZ3FszkKhy5ZhqC8SGMOh1sCrG1xjVq5AjDVWo7zuy6Bx/RYweKXpmEQUWM7/WxtY+ n4rUeUfoYiQUWKySJtYuS6XPMO945nbWvRQclDXllSTDShcn5Olig+RuRS2tGeFo7RgL HS2p3g4nfNn50Y2nXvQD6fQaGbt319WE0d/QreK7ihDn4rb+0D8h2cPfyVS+szQzch7/ d9v6hIM0tEwUD3ykgkX243Y6bwGfpjBVbYCFNM4GwteIiRP7wBBfElSU09kRGlH5cVJS +GwA== X-Gm-Message-State: AOUpUlFpKTyWcHHOqCEdQZFxDrnpQLzaJn//EDqNE2CNB7yYKXowuMLL r9wh+hPG0wn9yhkrgQKS/0I= X-Google-Smtp-Source: AAOMgpfMY6QrxtOPO6A3JABBSSog18aetzReVjzJBNJMBimSRXh0W8EflMJmq2yC8v/DMsQMPV7nyA== X-Received: by 2002:a5d:4a07:: with SMTP id m7-v6mr2289872wrq.8.1531850852489; Tue, 17 Jul 2018 11:07:32 -0700 (PDT) Original-Received: from rpluim (vav06-1-78-207-202-134.fbx.proxad.net. [78.207.202.134]) by smtp.gmail.com with ESMTPSA id 14-v6sm436362wmg.0.2018.07.17.11.07.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Jul 2018 11:07:31 -0700 (PDT) Mail-Followup-To: emacs-devel@gnu.org Mail-Copies-To: never Gmane-Reply-To-List: yes X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::436 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227511 Archived-At: Robert Pluim writes: > Paul Eggert writes: >> More generally, there's a lot of code duplication between this new >> function and what's already in the implementation of >> make-network-process. Intead, make-network-process should call this >> new function (or some C variant of it). So I split the common functionality into an internal function, and made the lisp function call that, and updated make-network-process to call it. Also a lispref entry and some tests (that uncovered a rather embarassing bug), all pushed to the netsec branch. Regards Robert