all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 32436@debbugs.gnu.org, roland winkler <winkler@gnu.org>
Subject: bug#32436: 26.1.50; Duplicate bibtex/BibTeX custom groups
Date: Wed, 15 Aug 2018 10:09:06 +0300	[thread overview]
Message-ID: <87ftzg85t9.fsf@tcd.ie> (raw)
In-Reply-To: <87ftzgxscv.fsf@gmail.com> (Noam Postavsky's message of "Tue, 14 Aug 2018 22:42:56 -0400")

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-Fix-duplicate-custom-group-names-in-bibtex.el.patch --]
[-- Type: text/x-diff, Size: 975 bytes --]

From 1ae2f6cba8bd03d64892b6e3d9aeb0200d3d9054 Mon Sep 17 00:00:00 2001
From: "Basil L. Contovounesios" <contovob@tcd.ie>
Date: Wed, 15 Aug 2018 10:03:23 +0300
Subject: [PATCH] Fix duplicate custom group names in bibtex.el

* lisp/textmodes/bibtex.el (bibtex-BibTeX-entry-alist):
Change :group from BibTeX to bibtex. (bug#32436)
---
 lisp/textmodes/bibtex.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/textmodes/bibtex.el b/lisp/textmodes/bibtex.el
index efab9d8e3b..6294b8026c 100644
--- a/lisp/textmodes/bibtex.el
+++ b/lisp/textmodes/bibtex.el
@@ -457,7 +457,7 @@ bibtex-BibTeX-entry-alist
 which is called to determine the initial content of the field.
 ALTERNATIVE if non-nil is an integer that numbers sets of
 alternatives, starting from zero."
-  :group 'BibTeX
+  :group 'bibtex
   :version "26.1"                       ; add Conference
   :type 'bibtex-entry-alist)
 (put 'bibtex-BibTeX-entry-alist 'risky-local-variable t)
-- 
2.18.0


[-- Attachment #2: Type: text/plain, Size: 774 bytes --]


Noam Postavsky <npostavs@gmail.com> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> I attach a patch which the presumed typo and then bumps the user
>> option's :version.  Is a change of custom group significant enough to
>> justify this, or should the :version be left alone?
>
> I'd say no, since there is no need for users to review their settings of
> this option because of this.  And if we look at the associated *Help*
> text:
>
>     This variable was introduced, or its default value was changed, in
>     version 26.2 of Emacs.
>
> That wouldn't be correct, since you haven't introduced, nor changed the
> default value of the variable in your patch.

Fair enough; I've removed the :version change from the attached patch.

Thanks,

-- 
Basil

  reply	other threads:[~2018-08-15  7:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-14 13:35 bug#32436: 26.1.50; Duplicate bibtex/BibTeX custom groups Basil L. Contovounesios
2018-08-14 13:43 ` Basil L. Contovounesios
2018-08-15  2:42   ` Noam Postavsky
2018-08-15  7:09     ` Basil L. Contovounesios [this message]
2018-08-17 19:38       ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftzg85t9.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=32436@debbugs.gnu.org \
    --cc=npostavs@gmail.com \
    --cc=winkler@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.