From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#32630: 26; [REGRESSION] `dired-query' key help (`help-form-show') Date: Tue, 04 Sep 2018 22:09:39 +0200 Message-ID: <87ftypqb24.fsf@web.de> References: <16c2c07a-512e-41cf-89d6-a3ef73b62cc3@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1536091689 6754 195.159.176.226 (4 Sep 2018 20:08:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Sep 2018 20:08:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 32630@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 04 22:08:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxHcK-0001cX-9W for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Sep 2018 22:08:04 +0200 Original-Received: from localhost ([::1]:52477 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxHeQ-0007hX-L0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Sep 2018 16:10:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxHeK-0007fD-Ds for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 16:10:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxHeE-0005EV-Nd for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 16:10:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41008) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fxHeE-0005E9-Fs for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 16:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fxHeE-00020c-1R for bug-gnu-emacs@gnu.org; Tue, 04 Sep 2018 16:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Sep 2018 20:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32630 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32630-submit@debbugs.gnu.org id=B32630.15360917947697 (code B ref 32630); Tue, 04 Sep 2018 20:10:01 +0000 Original-Received: (at 32630) by debbugs.gnu.org; 4 Sep 2018 20:09:54 +0000 Original-Received: from localhost ([127.0.0.1]:46025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxHe5-000204-TN for submit@debbugs.gnu.org; Tue, 04 Sep 2018 16:09:54 -0400 Original-Received: from mout.web.de ([212.227.15.14]:55841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxHe2-0001zl-3f for 32630@debbugs.gnu.org; Tue, 04 Sep 2018 16:09:50 -0400 Original-Received: from drachen.dragon ([94.216.13.226]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MZliY-1gAxyf46UI-00LZy4; Tue, 04 Sep 2018 22:09:40 +0200 In-Reply-To: <16c2c07a-512e-41cf-89d6-a3ef73b62cc3@default> (Drew Adams's message of "Mon, 3 Sep 2018 18:04:23 -0700 (PDT)") X-Provags-ID: V03:K1:T3BEbi99K4q+EDQOFMQ9UmbezT8wVW+9q9Syw8ii5F8oYOvR0Bd d8ST2InUGqBT9iHs0xZiVipBA8TmZCMRyCnWRE4i96PAJGYWQ6IAit4R6fism2g8VJEsa6j dmClQX1jnu/BI+R+sV/e7St2caaYPf8/mIc+QXdDUxePNS9UcKp0hLmO1KyHmwY6G73f/TH L5os50B0MYc8InIfSuw1A== X-UI-Out-Filterresults: notjunk:1;V01:K0:P/RguHs4qlo=:Oclr1vwv3cmfFjxt732AqF udLA+gUiwM6jjQfDGMoUChy3v33RrWAYVJ2Yaldidl/Cqx7f2wypQxnDLOVwA/CjeTFGEcMl7 Yc7LjOQDFZ/M5Ei4Uj4ThQPDTr/Jj/xNEjiSnwG9AFETl/f8dq/TIWO4b4QUTAbvMHgtjdm9W 2XYGjKkLdeyup1ZhVp8vVfKPo2pleqMUWq6G5WDE6uh2cDzuHl+//6KkcFO+VJQM5s2VEG2tP f1mkR6CjUpMAzcXY03T75oUn8E1PBSxKYJsNUIbLk+BHds/Ib4O+PEhvt78S5+2UlQ3i7WK1e OyOCNonTfEbnwnDMe83GDhy0TSOsQnCX5+Bz6sC66pxNj5tUA/nwz1PEPW2l7i8s2q9y+ngpN Dxw4u/b8pjeDPxhuNRXolWRLHUUBd9TYlb8qj1ABN5SbTjp/LA3pi8VRsX4+2tENgrpTrlkz+ PFmdVDy3u1f9XfF5i78xBOCROysx1uAaZkTrPFHzy0pfDPp38hcz1ZzVi1rJ05zTUXTuRhTef S1ZjwfXAa+RLqHrzAsy+XKy6n5c8juX9inDo2BcVKcq60uu7+fgOtHWoglzhtV+giqMySaay6 RRnFW7HGCBLGLVFTtYznu0jsWnkVwQo0sOTeo8IHkwotUa9LenhfQlW3uq6/8h7uXTew/0SZf J5+knvPrmlAY0XTrp3fOVBNpz8OeSK22GEh4pbsEQ9EuA/49PLecJrFR935TgMAQojeI4mylu rbKZMg5WXGrg0b29+fdzbOPTvn11+ZDoQ61h9115i4U0WxLtZyAq6IFe0V5OG5gP/CnTEs2y X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150017 Archived-At: --=-=-= Content-Type: text/plain Drew Adams writes: > It seems like the "to" in the prompt is being evaluated as a variable. > Perhaps there is a missing quote somewhere. It's not the "to" in the prompt but a local variable in `dired-create-files'. It's indeed a quoting problem. It existed for a long time but I think it was originally negated by dynamic binding mode until dired-aux was changed to lexical binding. Here is a trivial fix: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-FIX-bug-32630.patch >From 5ae01a1079cac88cdf6b38f419a6f8b1b874c97c Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Tue, 4 Sep 2018 22:00:11 +0200 Subject: [PATCH] FIX bug#32630 --- lisp/dired-aux.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index 21ee50ce5c..dc34037be9 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -1731,7 +1731,7 @@ dired-create-files (let* ((overwrite (file-exists-p to)) (dired-overwrite-confirmed ; for dired-handle-overwrite (and overwrite - (let ((help-form '(format-message "\ + (let ((help-form (format-message "\ Type SPC or `y' to overwrite file `%s', DEL or `n' to skip to next, ESC or `q' to not overwrite any of the remaining files, -- 2.18.0 --=-=-= Content-Type: text/plain Michael. --=-=-=--