bug#32630: 26; [REGRESSION] `dired-query' key help (`help-form-show')

[Michael Heerdegen <michael_heerdegen@web.de>]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Drew Adams <drew.adams@oracle.com> writes:

> It seems like the "to" in the prompt is being evaluated as a variable.
> Perhaps there is a missing quote somewhere.

It's not the "to" in the prompt but a local variable in
`dired-create-files'.  It's indeed a quoting problem.  It existed for a
long time but I think it was originally negated by dynamic binding mode
until dired-aux was changed to lexical binding.  Here is a trivial fix:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-FIX-bug-32630.patch --]
[-- Type: text/x-diff, Size: 862 bytes --]

From 5ae01a1079cac88cdf6b38f419a6f8b1b874c97c Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Tue, 4 Sep 2018 22:00:11 +0200
Subject: [PATCH] FIX bug#32630

---
 lisp/dired-aux.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index 21ee50ce5c..dc34037be9 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -1731,7 +1731,7 @@ dired-create-files
           (let* ((overwrite (file-exists-p to))
                  (dired-overwrite-confirmed ; for dired-handle-overwrite
                   (and overwrite
-                       (let ((help-form '(format-message "\
+                       (let ((help-form (format-message "\
 Type SPC or `y' to overwrite file `%s',
 DEL or `n' to skip to next,
 ESC or `q' to not overwrite any of the remaining files,
-- 
2.18.0


[-- Attachment #3: Type: text/plain, Size: 11 bytes --]



Michael.