From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: Bignum speedup patch causes crash at startup Date: Tue, 04 Sep 2018 16:34:02 -0600 Message-ID: <87ftyorixx.fsf@tromey.com> References: <83tvn5xicp.fsf@gnu.org> <86lg8hf3dy.fsf@gmail.com> <8c20c37f-983b-08e6-177f-9223f33914fc@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1536100344 29340 195.159.176.226 (4 Sep 2018 22:32:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Sep 2018 22:32:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: Tom Tromey , Andy Moreton , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 05 00:32:20 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fxJrv-0007Vd-QX for ged-emacs-devel@m.gmane.org; Wed, 05 Sep 2018 00:32:20 +0200 Original-Received: from localhost ([::1]:52873 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxJu1-0000C9-Us for ged-emacs-devel@m.gmane.org; Tue, 04 Sep 2018 18:34:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35994) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fxJtv-0000Bs-Ha for emacs-devel@gnu.org; Tue, 04 Sep 2018 18:34:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fxJtq-0005si-9b for emacs-devel@gnu.org; Tue, 04 Sep 2018 18:34:23 -0400 Original-Received: from gateway20.websitewelcome.com ([192.185.49.40]:14852) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fxJto-0005hl-Q6 for emacs-devel@gnu.org; Tue, 04 Sep 2018 18:34:17 -0400 Original-Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 2650D400D056A for ; Tue, 4 Sep 2018 17:34:04 -0500 (CDT) Original-Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id xJtcfm9kWaSeyxJtcfF218; Tue, 04 Sep 2018 17:34:04 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rQCaA1fQaOo59w9VugUKVvlFKLiTcRmd3vnCtfA0XqY=; b=e884moDE0j3F0ogEV+ukyMKj6W 6M3VaUwqosE/KagHfs6z8fB/5wIne1jDo6qf1cUqmmnO8RkjB7q2Qe7s31fi9ba46/3qBoj8TRTrp PIN47eaBmxSePMv692dY2EJmf; Original-Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:45996 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fxJtb-0041my-TM; Tue, 04 Sep 2018 17:34:04 -0500 X-Attribution: Tom In-Reply-To: <8c20c37f-983b-08e6-177f-9223f33914fc@cs.ucla.edu> (Paul Eggert's message of "Tue, 4 Sep 2018 14:11:06 -0700") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.85.72 X-Source-L: No X-Exim-ID: 1fxJtb-0041my-TM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-85-72.hlrn.qwest.net (bapiya) [75.166.85.72]:45996 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 192.185.49.40 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229273 Archived-At: >>>>> "Paul" == Paul Eggert writes: Paul> Andy Moreton wrote: >> Tom added support in commit fb26c9fd69 ("Make purecopy work for >> bignums"), so if that causes problems then it may need to be revisited. Paul> That code is never used and it wouldn't hurt to remove it as per the Paul> attached. I'll CC: Tom to see if he has an opinion. I added it because someone (Andy I think but this illness is affecting my memory somewhat) asked for it. It seemed not impossible for something to try to dump a bignum. But, if it isn't needed, then IMO that's fine. Tom