From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 33005@debbugs.gnu.org
Subject: bug#33005: 27.0.50; Data loss with Gnus registry
Date: Wed, 10 Oct 2018 16:05:50 -0700 [thread overview]
Message-ID: <87ftxdl7w1.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <874ldtlcks.fsf@web.de> (Michael Heerdegen's message of "Wed, 10 Oct 2018 23:24:35 +0200")
On 10/10/18 23:24 PM, Michael Heerdegen wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> (registry-collect-prune-candidates gnus-registry-db
>> (registry-size gnus-registry-db) nil)
>
> Ok, I managed to debug this.
>
> The entry is indeed pruned. It looks like
>
> Key: "<153...>"
>
> Value: ((mark Important) (subject ...) ...)
>
> In the `registry-collect-prune-candidates' method, the variable PRECIOUS
> is bound to the list (gnorb-ids org-tags mark).
>
> AFAIU, since PRECIOUS-P is defined as
>
> (lambda (entry-key) (cdr (memq (car-safe entry-key) precious)))
>
> and the symbol mark comes last in the PRECIOUS list, the `cdr' of the
> `memq' call is nil. If I remove the `cdr' call, the entry isn't pruned
> any more. I also don't get why that `cdr' is there. Or is my value of
> PRECIOUS illegal?
Nice work! I have no idea why that `cdr' is in there, and as the value
is used as a boolean it seems totally superfluous. I don't use registry
marks, which is probably the reason I never noticed (I didn't write this
code).
I don't see any reason not to remove the `cdr', and will do so unless
someone objects cogently, soon.
Thanks,
Eric
next prev parent reply other threads:[~2018-10-10 23:05 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 13:24 bug#33005: 27.0.50; Data loss with Gnus registry Michael Heerdegen
2018-10-10 14:56 ` Eric Abrahamsen
2018-10-10 15:17 ` Michael Heerdegen
2018-10-10 16:08 ` Eric Abrahamsen
2018-10-10 20:23 ` Michael Heerdegen
2018-10-10 21:24 ` Michael Heerdegen
2018-10-10 23:05 ` Eric Abrahamsen [this message]
2018-10-11 12:44 ` Michael Heerdegen
2018-10-11 13:10 ` Michael Heerdegen
2018-10-11 18:12 ` Eric Abrahamsen
2018-10-11 20:28 ` Michael Heerdegen
2018-10-11 22:09 ` Eric Abrahamsen
2018-10-11 22:20 ` Michael Heerdegen
2018-10-11 22:26 ` Eric Abrahamsen
2018-10-12 14:22 ` Michael Heerdegen
2018-10-12 16:57 ` Eric Abrahamsen
2018-10-11 18:53 ` Eli Zaretskii
2018-10-11 18:57 ` Eric Abrahamsen
2018-10-11 20:08 ` Michael Heerdegen
2018-10-12 4:24 ` Eli Zaretskii
2018-10-12 11:04 ` Michael Heerdegen
2018-10-12 12:51 ` Eli Zaretskii
2018-10-12 14:46 ` Michael Heerdegen
2018-10-12 16:58 ` Eric Abrahamsen
2019-09-24 1:35 ` Michael Heerdegen
2019-09-24 3:34 ` Eric Abrahamsen
2019-10-01 23:37 ` Eric Abrahamsen
2019-10-14 9:53 ` Michael Heerdegen
2019-10-14 17:51 ` Eric Abrahamsen
2019-10-15 14:28 ` Michael Heerdegen
2019-10-15 20:11 ` Eric Abrahamsen
2019-10-16 9:03 ` Michael Heerdegen
2019-10-16 15:46 ` Eric Abrahamsen
2019-10-17 8:21 ` Michael Heerdegen
2019-10-17 15:53 ` Eric Abrahamsen
2019-10-18 9:18 ` Michael Heerdegen
2019-10-18 14:44 ` Michael Heerdegen
2019-10-19 2:05 ` Phil Sainty
2019-10-19 14:31 ` Michael Heerdegen
2019-10-19 22:12 ` Phil Sainty
2019-10-26 8:02 ` Michael Heerdegen
2019-10-26 15:35 ` Eric Abrahamsen
2019-11-18 9:17 ` Phil Sainty
2019-10-18 14:46 ` Michael Heerdegen
2019-10-18 19:07 ` Eric Abrahamsen
2019-10-18 19:09 ` Eric Abrahamsen
2019-10-18 19:23 ` Michael Heerdegen
2019-10-18 19:24 ` Eric Abrahamsen
2019-10-19 14:25 ` Michael Heerdegen
2019-10-19 18:06 ` Eric Abrahamsen
2019-10-18 19:06 ` Eric Abrahamsen
2019-10-16 9:30 ` Michael Heerdegen
2019-10-16 15:49 ` Eric Abrahamsen
2019-10-17 8:32 ` Michael Heerdegen
2019-10-17 10:23 ` Michael Heerdegen
2019-10-17 15:54 ` Eric Abrahamsen
2019-10-18 3:08 ` Richard Stallman
2019-10-18 9:50 ` Michael Heerdegen
2019-11-26 0:17 ` Michael Heerdegen
2019-11-26 0:51 ` Eric Abrahamsen
2019-11-26 16:32 ` Michael Heerdegen
2019-11-26 18:45 ` Eric Abrahamsen
2019-11-26 20:08 ` Michael Heerdegen
2019-11-26 20:41 ` Eric Abrahamsen
2019-11-26 20:45 ` Michael Heerdegen
2019-11-26 20:48 ` Eric Abrahamsen
2019-11-26 20:54 ` Michael Heerdegen
2019-11-28 8:43 ` Eric Abrahamsen
2019-11-28 16:25 ` Michael Heerdegen
2019-11-28 23:55 ` Eric Abrahamsen
2019-11-29 12:36 ` Michael Heerdegen
2019-12-03 9:19 ` Eric Abrahamsen
2019-12-04 16:10 ` Michael Heerdegen
2019-12-04 17:26 ` Eric Abrahamsen
2019-12-04 20:41 ` Michael Heerdegen
2019-12-04 20:53 ` Eric Abrahamsen
2019-12-04 21:02 ` Michael Heerdegen
2019-12-04 21:16 ` Eric Abrahamsen
2019-12-04 21:51 ` Michael Heerdegen
2019-12-05 0:51 ` Eric Abrahamsen
2019-12-08 15:48 ` Michael Heerdegen
2019-12-08 20:52 ` Eric Abrahamsen
2019-12-09 19:38 ` Michael Heerdegen
2019-12-09 22:29 ` Eric Abrahamsen
2019-12-09 23:07 ` Michael Heerdegen
2019-12-10 0:24 ` Eric Abrahamsen
2019-12-10 2:30 ` Michael Heerdegen
2019-12-10 23:31 ` Eric Abrahamsen
2019-12-15 17:07 ` Michael Heerdegen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftxdl7w1.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=33005@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.