all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: 34481@debbugs.gnu.org
Subject: bug#34481: 27.0.50; cl-flet, cl-labels and lambda expressions
Date: Tue, 19 Feb 2019 01:22:25 +0100	[thread overview]
Message-ID: <87ftskeif2.fsf@web.de> (raw)
In-Reply-To: <87r2c9iz02.fsf@web.de> (Michael Heerdegen's message of "Fri, 15 Feb 2019 03:09:17 +0100")

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Hi,
>
> two related little issues:
>
> 1.  `cl-flet's edebug spec only works with one allowed syntax, when all
> bindings look like (FUNC ARGLIST BODY...).  The second possible syntax
> (FUNC EXP) makes edebug barf, no edebugging possible :-(

Who knows if this is correct?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Extend-debug-spec-of-cl-flet.patch --]
[-- Type: text/x-diff, Size: 1100 bytes --]

From 3859414d19bc9de1593af7276decafe9b34ee628 Mon Sep 17 00:00:00 2001
From: Michael Heerdegen <michael_heerdegen@web.de>
Date: Tue, 19 Feb 2019 01:12:07 +0100
Subject: [PATCH] Extend debug spec of cl-flet

* lisp/emacs-lisp/cl-macs.el (cl-flet): Extend debug spec to cover
definitions of the form (FUNC EXP).
---
 lisp/emacs-lisp/cl-macs.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
index 5faa055f99..9f79b1a7cf 100644
--- a/lisp/emacs-lisp/cl-macs.el
+++ b/lisp/emacs-lisp/cl-macs.el
@@ -2044,7 +2044,9 @@ cl-flet
 info node `(cl) Function Bindings' for details.

 \(fn ((FUNC ARGLIST BODY...) ...) FORM...)"
-  (declare (indent 1) (debug ((&rest (cl-defun)) cl-declarations body)))
+  (declare (indent 1)
+           (debug ((&rest [&or (&define name form) (cl-defun)])
+                   cl-declarations body)))
   (let ((binds ()) (newenv macroexpand-all-environment))
     (dolist (binding bindings)
       (let ((var (make-symbol (format "--cl-%s--" (car binding))))
--
2.20.1


[-- Attachment #3: Type: text/plain, Size: 221 bytes --]


I wasn't sure if I need to use "def-form" instead of "form" (I guess
not) or if some "nil" or "gate" magic is needed in addition.

And to which branch should I install it if it happens to be correct?


Thanks,

Michael.

  reply	other threads:[~2019-02-19  0:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15  2:09 bug#34481: 27.0.50; cl-flet, cl-labels and lambda expressions Michael Heerdegen
2019-02-19  0:22 ` Michael Heerdegen [this message]
2019-02-19  1:03 ` Michael Heerdegen
2019-02-19  2:36   ` Michael Heerdegen
2019-10-03 22:28 ` Stefan Kangas
2019-10-17 10:36   ` Michael Heerdegen
2019-10-17 10:45     ` Stefan Kangas
2019-10-17 12:31       ` Michael Heerdegen
2019-10-17 18:20         ` Michael Heerdegen
2019-11-07 13:44         ` Stefan Kangas
2021-03-01 15:53         ` Lars Ingebrigtsen
2021-03-01 16:23           ` Stefan Monnier
2021-03-01 23:15             ` Michael Heerdegen
2021-03-01 23:18           ` Michael Heerdegen
2021-03-01 23:29             ` Lars Ingebrigtsen
2021-03-01 23:49               ` Michael Heerdegen
2021-03-02  1:11                 ` Michael Heerdegen
2021-03-02  6:53                   ` Lars Ingebrigtsen
2021-03-02  2:41                 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftskeif2.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=34481@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.