From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 34974@debbugs.gnu.org
Subject: bug#34974: 27.0.50; Moving article error with duplicate suppression disabled
Date: Sun, 24 Mar 2019 08:05:14 -0700 [thread overview]
Message-ID: <87ftrcmhxx.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <871s2wpedf.fsf@tcd.ie> (Basil L. Contovounesios's message of "Sun, 24 Mar 2019 14:07:31 +0000")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> With gnus-suppress-duplicates left at its default value of nil, trying
> to move an article with 'B m <group>' gives me the following backtrace:
>
> Debugger entered--Lisp error: (wrong-type-argument hash-table-p nil)
> remhash("<redacted-message-id>" nil)
> gnus-dup-unsuppress-article(1988)
> gnus-summary-move-article(nil)
> funcall-interactively(gnus-summary-move-article nil)
> call-interactively(gnus-summary-move-article nil nil)
> command-execute(gnus-summary-move-article)
>
> I'm no expert, and I haven't tried reproducing this with a minimal
> config, but I think gnus-summary-move-article should not call
> gnus-dup-unsuppress-article when gnus-suppress-duplicates is nil, right?
>
> This issue seems to have been uncovered by the switch to hash-tables in
> bug#33653. Previously, gnus-dup-unsuppress-article called unintern,
> which would not complain when its second argument gnus-dup-hashtb was
> nil, even though it probably should have.
>
> Patch to follow.
Thanks, Basil!
It looks like the only other call to `gnus-dup-unsuppress-articles' is
wrapped in a check for `gnus-suppress-duplicates' -- I suppose it would
be enough just to wrap this one as well?
Eric
next prev parent reply other threads:[~2019-03-24 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 14:07 bug#34974: 27.0.50; Moving article error with duplicate suppression disabled Basil L. Contovounesios
2019-03-24 14:59 ` Basil L. Contovounesios
2019-03-24 15:06 ` Eric Abrahamsen
2019-04-10 13:40 ` Basil L. Contovounesios
2019-03-24 15:05 ` Eric Abrahamsen [this message]
2019-03-24 17:08 ` Basil L. Contovounesios
2019-03-24 17:14 ` Eric Abrahamsen
2019-03-25 4:16 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftrcmhxx.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=34974@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.