From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#34847: 27.0.50; auto-revert-buffers occasionally selects a killed buffer Date: Sat, 06 Apr 2019 02:55:05 +0100 Message-ID: <87ftqvlwxy.fsf@tcd.ie> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="249363"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34847@debbugs.gnu.org To: Dale Sedivec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 06 03:56:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCaZ6-0012lc-W5 for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2019 03:56:17 +0200 Original-Received: from localhost ([127.0.0.1]:49323 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCaZ5-0000Ej-T6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 05 Apr 2019 21:56:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCaYv-0000Ed-SR for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 21:56:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCaYu-0000Lw-CI for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 21:56:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32894) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCaYs-0000Jx-1h for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 21:56:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hCaYr-0004Ha-Uf for bug-gnu-emacs@gnu.org; Fri, 05 Apr 2019 21:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Apr 2019 01:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34847 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34847-submit@debbugs.gnu.org id=B34847.155451571716386 (code B ref 34847); Sat, 06 Apr 2019 01:56:01 +0000 Original-Received: (at 34847) by debbugs.gnu.org; 6 Apr 2019 01:55:17 +0000 Original-Received: from localhost ([127.0.0.1]:46438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCaY9-0004GE-1X for submit@debbugs.gnu.org; Fri, 05 Apr 2019 21:55:17 -0400 Original-Received: from mail-ed1-f49.google.com ([209.85.208.49]:36606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCaY6-0004Fv-13 for 34847@debbugs.gnu.org; Fri, 05 Apr 2019 21:55:15 -0400 Original-Received: by mail-ed1-f49.google.com with SMTP id s16so7055564edr.3 for <34847@debbugs.gnu.org>; Fri, 05 Apr 2019 18:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=t3/4Gaa9UAPBYU9odfKXt0nIlMWNNa0+9KgyZOOCbTo=; b=Cn7U9uiadJwHNJaKpdquPzO/PX+zJPa1wqk+32vgZnItU6NtiCOxB+MG9rzKoTfiNJ 7zwdzy7hc2TzV4B8rGARphQxghIJbZJocgZoXEIfvKYpouzD4GVvNYVLqkOYtBLycNTF Tqs4KJIt5qHkrIIqf9DxFLHMBCLJuEJR4yFiadKjv+deXhEqgsy9hUkmERAG3lWD1eyJ mQDvRzv2+uoGsY+0pVhCGRXYL8MSqer2PUUB7lT+i9lib/BOkOQqlQ6b7ZXPaucvP5RV lXr9r1C9wjaAogBJld7fVdtfHRw790HMFFpUv4hMgWvjbEZB+XjsJ8YiGkJXVUtrdBEM Ycuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=t3/4Gaa9UAPBYU9odfKXt0nIlMWNNa0+9KgyZOOCbTo=; b=qrS+PAoMYoJMaJ7U8sxfuMZyseMdffg1yMNFKTZI7dH1DKwoxgOW+Yeyqe8GVE1VoV o6sA2fINMa2yqJv+daLFNxLys4CI0JshMd3tHr2cER7tzz8VqoLOVhlhOrlkMRsgCC+9 +3PwTq7nWMTW6lTaQZlmtFTO4h0sUpJ4vbRh9SeW+UwtSc4VF4cSVDiGdHNXR8erIMDM MksD0/141ait6KkSXCDYnuhIFOHbe++r1aq25y9TXPQaxAcAht1BxHzFcI4sIsbKG/03 AxvDL1YP8HkZ71q1EJ+9pzm331yulRr1h1QKGBJoY+Cv48+PcVbJv9qfGeAwAWeKtTrn R2MA== X-Gm-Message-State: APjAAAU16HVsYWUct0czeTlhI3+ut9SvDXHwAOCaCNgLY43ftMZuFhaC 4o+fwwkys+8bjQNuC67I/LKm2w== X-Google-Smtp-Source: APXvYqyy3krkMUcbKRRAtufEbFqx4Y7EQDQ/zJL87jpfFyUVU/IMRUHtDjFYLFdi2Dc5j0mhJ6TpXg== X-Received: by 2002:a50:aa0f:: with SMTP id o15mr10317855edc.129.1554515707942; Fri, 05 Apr 2019 18:55:07 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:20c2:134e:4f3a:683a]) by smtp.gmail.com with ESMTPSA id r14sm6966071edd.87.2019.04.05.18.55.06 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 05 Apr 2019 18:55:06 -0700 (PDT) In-Reply-To: (Dale Sedivec's message of "Wed, 13 Mar 2019 13:03:35 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157243 Archived-At: --=-=-= Content-Type: text/plain Dale Sedivec writes: > Lately, while in the process of using Magit, I've frequently gotten > "Selecting deleting buffer" errors. Same here. > I have global-auto-revert-mode on. I *suspect* this happens because > *something* kills a buffer between when auto-revert-buffers collects > the list of buffers with (buffer-list) and when auto-revert-buffers > starts its final traversal of buffers in bufs (which starts out as > (buffer-list) in global-auto-revert-mode). My case is slightly different. I enable auto-revert-mode neither locally nor globally, so Magit automatically enables magit-auto-revert-mode instead. This means that the killed buffers causing the auto-revert-buffers timer to choke are present in auto-revert-buffer-list, rather than (buffer-list). Normally, killed buffers are removed from auto-revert-buffer-list thanks to the local kill-buffer-hook function auto-revert-remove-current-buffer. But instrumenting get-buffer-create and kill-buffer revealed that kill-buffer-hook wasn't run sometimes, specifically when an uninitialised inhibit_buffer_hooks happened to be non-zero. Eli, is the following TRT? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-leave-inhibit_buffer_hooks-uninitialized.patch >From 3c519bd52911db44bb3f92dcc722812d8d69a2c6 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sat, 6 Apr 2019 02:41:16 +0100 Subject: [PATCH] Don't leave inhibit_buffer_hooks uninitialized * src/buffer.c (Fget_buffer_create): Explicitly initialize inhibit_buffer_hooks. (bug#34847) --- src/buffer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/buffer.c b/src/buffer.c index c0f7521c9e..c5d8ee2629 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -588,6 +588,8 @@ even if it is dead. The return value is never nil. */) && strncmp (SSDATA (name), SSDATA (Vcode_conversion_workbuf_name), SBYTES (Vcode_conversion_workbuf_name)) == 0) b->inhibit_buffer_hooks = true; + else + b->inhibit_buffer_hooks = false; bset_undo_list (b, SREF (name, 0) != ' ' ? Qnil : Qt); -- 2.20.1 --=-=-= Content-Type: text/plain Between Michael's patch[1] for autorevert.el and this, I think the issue should be solved. [1]: https://debbugs.gnu.org/34847#8 Thanks, -- Basil --=-=-=--