From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#33653: 27.0.50; Change Gnus obarrays-as-hash-tables into real hash tables Date: Mon, 08 Apr 2019 19:01:08 -0700 Message-ID: <87ftqsey3f.fsf@ericabrahamsen.net> References: <8736raz3ec.fsf@ericabrahamsen.net> <87y392xoht.fsf@ericabrahamsen.net> <87imxzxa4s.fsf@ericabrahamsen.net> <87a7hn3h3w.fsf@ericabrahamsen.net> <87a7hhtinz.fsf@ericabrahamsen.net> <87o95gqrfm.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="7296"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , Bastien Guerry , Adam =?UTF-8?Q?Sj=C3=B8gren?= , 33653@debbugs.gnu.org To: Katsumi Yamaoka Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 09 04:02:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDg5d-0001kP-Cq for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Apr 2019 04:02:21 +0200 Original-Received: from localhost ([127.0.0.1]:33687 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDg5c-00025U-3h for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Apr 2019 22:02:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDg5S-000259-W9 for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 22:02:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDg5R-0004wZ-N2 for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 22:02:10 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36862) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hDg5K-0004py-Kl for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 22:02:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hDg5K-000530-Bu for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2019 22:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2019 02:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33653 X-GNU-PR-Package: emacs Original-Received: via spool by 33653-submit@debbugs.gnu.org id=B33653.155477527819349 (code B ref 33653); Tue, 09 Apr 2019 02:02:02 +0000 Original-Received: (at 33653) by debbugs.gnu.org; 9 Apr 2019 02:01:18 +0000 Original-Received: from localhost ([127.0.0.1]:50406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDg4b-000521-Ko for submit@debbugs.gnu.org; Mon, 08 Apr 2019 22:01:17 -0400 Original-Received: from ericabrahamsen.net ([52.70.2.18]:44862 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hDg4a-00051o-0M for 33653@debbugs.gnu.org; Mon, 08 Apr 2019 22:01:16 -0400 Original-Received: from localhost (97-126-93-115.tukw.qwest.net [97.126.93.115]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 16364FA05B; Tue, 9 Apr 2019 02:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ericabrahamsen.net; s=mail; t=1554775270; bh=/TqE14strgtOyX0+KChXq8ag6OB3D/yKA+9mbNwrxeg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZdoBkhX4gEd5t7pldnJxFXscelJixF5enbw/NBBDkfChewEcBWHFu5qhpQKOtK5FU KnWzFeAaXV6+fSnxbk6Sdtfwam1BnUzzi3LL3LFRXGoLlZ0hTWdLXJGRbE2jy5AlNc IhzOhh24gO36gOAx1T3E44wBOJUfDxNVMsPiJcUU= In-Reply-To: (Katsumi Yamaoka's message of "Tue, 09 Apr 2019 09:55:23 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157386 Archived-At: On 04/09/19 09:55 AM, Katsumi Yamaoka wrote: > On Mon, 08 Apr 2019 11:31:57 -0700, Eric Abrahamsen wrote: >> On 04/08/19 17:13 PM, Katsumi Yamaoka wrote: >>> - (with-temp-buffer >>> + (mm-with-unibyte-buffer >>> (insert-buffer-substring cur) > >> I was asking on emacs.devel about that, and with Andreas' help came up >> with the attached patch. It's a terrible hack, but it seems to work, and >> I think would be good as an intermediate step. > >> What you're doing -- changing the unibyte/multibyte status of the >> buffers -- is I think part of the final, more correct solution to the >> problem, that will leave group names decoded everywhere. But I would >> like to Gnus back into an intermediate working state before tackling >> that... > >> What do you think? > > Whatever we should do finally, isn't it necessary to make Gnus on > Emacs master work now anyway even if it is immature? Those who > like the *latest* code by any means (me included) would be coming > to use it sooner or later. So, I'd like you to install to master > a fix whatever makes Gnus work. Yes, that's what I was saying! Do the minimum needed now to get things working again, then I'll be more careful putting a more thorough fix later. >> --- a/lisp/gnus/gnus-start.el >> +++ b/lisp/gnus/gnus-start.el > [...] >> (setq group (read cur) >> + group >> + (encode-coding-string >> + (cond ((numberp group) >> + (number-to-string group)) >> + ((symbolp group) >> + (symbol-name group)) >> + ((stringp group) >> + group)) >> + 'latin-1)))) > > Makes sense to me. Though encoding the one having already encoded > looks redundant, I have no idea other than this and my patch, and > benchmark reports there is no notably difference in speed between > this and my patch. Yes, it's ugly, but hopefully it's temporary. I am glad that it doesn't affect speed, though. > Anyway I verified it works for listing the nnml:=E3=83=86=E3=82=B9=E3=83= =88 group. > >> --- a/lisp/gnus/nnmail.el >> +++ b/lisp/gnus/nnmail.el > >> --- a/lisp/gnus/nnml.el >> +++ b/lisp/gnus/nnml.el > > Verified that those patches enable updating groups by `M-g'. > >> --- a/lisp/gnus/nnrss.el >> +++ b/lisp/gnus/nnrss.el > > Verified that I can read some feeds. Thanks very much. I'll push this now, and then see what else needs cleaning up. Eric