From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35285: 27.0.50; Bug in image--set-property; setf Date: Wed, 17 Apr 2019 18:43:37 +0100 Message-ID: <87ftqg8r3q.fsf@tcd.ie> References: <87k1fvd0cw.fsf@tullinup.koldfront.dk> <87r2a092jv.fsf@tcd.ie> <83zhooeeyb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="151469"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: asjo@koldfront.dk, 35285@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 17 19:44:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hGobY-000dIk-Sj for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Apr 2019 19:44:17 +0200 Original-Received: from localhost ([127.0.0.1]:57278 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGobX-0004Oy-QY for geb-bug-gnu-emacs@m.gmane.org; Wed, 17 Apr 2019 13:44:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hGobL-0004NP-HH for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2019 13:44:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hGobK-0005UW-Li for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2019 13:44:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55418) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hGobK-0005U8-Bo for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2019 13:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hGobJ-0005T5-R2 for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2019 13:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Apr 2019 17:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35285 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35285-submit@debbugs.gnu.org id=B35285.155552302920992 (code B ref 35285); Wed, 17 Apr 2019 17:44:01 +0000 Original-Received: (at 35285) by debbugs.gnu.org; 17 Apr 2019 17:43:49 +0000 Original-Received: from localhost ([127.0.0.1]:40729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGob6-0005SV-5V for submit@debbugs.gnu.org; Wed, 17 Apr 2019 13:43:48 -0400 Original-Received: from mail-ed1-f51.google.com ([209.85.208.51]:33140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hGob4-0005SF-7I for 35285@debbugs.gnu.org; Wed, 17 Apr 2019 13:43:46 -0400 Original-Received: by mail-ed1-f51.google.com with SMTP id d55so20934004ede.0 for <35285@debbugs.gnu.org>; Wed, 17 Apr 2019 10:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GWLd31rznZPu6Iv31f423fj6F2JiOw+60EnpslClaVU=; b=dJWAy7uX2nFOF9/dXfr4PL5XVjhrwXWx0cAIrc8Xj7LYMsNR/frLB1qXlsgc+a6TPG 3SWmjZ7JJWGeB68FqSbW/ZwPD7KGIV+vX8/mRaxL4mHF4QkYb3GKEmjJsKkfpyhGljbw quVHArWYOz1Q9zxDDXqFeCOEj5M1XkheAdz3oM27W6Osrr1Ue5eOovN4nsk1wXhnEh1D Z/1iLIXzdFGI7+mvgcXcog+FIbhbafhfGo+88MuqgXLwRMB2G1NGUGEYXD55zxBK2OFB ScT6dlTSFjj59mtDdTnDxFt59PKrPEin98ykF1kwKToo/str/potfS3iWcIMLioi00rD fMkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=GWLd31rznZPu6Iv31f423fj6F2JiOw+60EnpslClaVU=; b=YPHBxVzyNKqLk1CcYTzBxnwvbRV3YWt9bVNA1oRobq+4HH2dQh2qk10hAAygBw97cx VRf322T+l4NduFPBUYyN0dV0lLgSLTbHLgzqg5w1zPrjXfc/CMliXCHeBJyPkfY3TCOa +XNg8zmhhkQ7grz8WHMt1qdilCbjk9QTAwCBw4wz7pFyeeeR+aipOEB7nHwdfM8keGI6 uK/sHI+c4iUSHCdVF+gjgA1L9ceJalGu+JpXRe4dPcMRUjPtBXd6FN/BYyPuf30XxA8z wYYREjJavVMXzNaorZmAORqaJruBRlwOVwSo0Q7WQ2qOqE9MKlOnr5yz+v/y+DNWLnlY dB4A== X-Gm-Message-State: APjAAAWGULmE2rBSFyMyPZ7ERYhXRyLzV/H/U940cd368oB79mv8+Oqw 3wa0+O+9o+8m6NR50MF8QiIQWA== X-Google-Smtp-Source: APXvYqzoCam/WupRoTegIJgRyQqbBWdB3ac3F/OOCvK6UwwXSmvSJBd3z/W9da7pJCdVg9TghS6Szw== X-Received: by 2002:a50:a3b1:: with SMTP id s46mr54263629edb.99.1555523020173; Wed, 17 Apr 2019 10:43:40 -0700 (PDT) Original-Received: from localhost ([86.43.102.231]) by smtp.gmail.com with ESMTPSA id l20sm10198715ejb.30.2019.04.17.10.43.38 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 17 Apr 2019 10:43:39 -0700 (PDT) In-Reply-To: <83zhooeeyb.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 Apr 2019 20:09:32 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157771 Archived-At: Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Date: Wed, 17 Apr 2019 14:36:20 +0100 >> Cc: 35285@debbugs.gnu.org >> >> I agree that this is the problem, and the attached patch should fix >> that. Eli, should this go to emacs-26 or master? > > It's okay for emacs-26, but will :scale work there without > Imagemagick? Why did you need to use :scale in the tests? Any property will do, since the test is using a mocked image spec, and image--set-property is not sensitive to particular properties. In other words, I did not need to use :scale, but it will work regardless of Imagemagick. Is that okay? Thanks, -- Basil