From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: asjo@koldfront.dk, 35285@debbugs.gnu.org
Subject: bug#35285: 27.0.50; Bug in image--set-property; setf
Date: Wed, 17 Apr 2019 18:43:37 +0100 [thread overview]
Message-ID: <87ftqg8r3q.fsf@tcd.ie> (raw)
In-Reply-To: <83zhooeeyb.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 17 Apr 2019 20:09:32 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Date: Wed, 17 Apr 2019 14:36:20 +0100
>> Cc: 35285@debbugs.gnu.org
>>
>> I agree that this is the problem, and the attached patch should fix
>> that. Eli, should this go to emacs-26 or master?
>
> It's okay for emacs-26, but will :scale work there without
> Imagemagick? Why did you need to use :scale in the tests?
Any property will do, since the test is using a mocked image spec,
and image--set-property is not sensitive to particular properties.
In other words, I did not need to use :scale, but it will work
regardless of Imagemagick. Is that okay?
Thanks,
--
Basil
next prev parent reply other threads:[~2019-04-17 17:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 10:33 bug#35285: 27.0.50; Bug in image--set-property; setf Adam Sjøgren
2019-04-17 13:36 ` Basil L. Contovounesios
2019-04-17 17:09 ` Eli Zaretskii
2019-04-17 17:43 ` Basil L. Contovounesios [this message]
2019-04-17 18:33 ` Eli Zaretskii
2019-04-18 15:17 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftqg8r3q.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=35285@debbugs.gnu.org \
--cc=asjo@koldfront.dk \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.