* bug#35577: find-file-read-only docstring old
@ 2019-05-05 7:21 積丹尼 Dan Jacobson
2019-05-05 12:40 ` Noam Postavsky
0 siblings, 1 reply; 5+ messages in thread
From: 積丹尼 Dan Jacobson @ 2019-05-05 7:21 UTC (permalink / raw)
To: 35577
"open"? Don't you mean find-file?:
find-file-read-only is an interactive compiled Lisp function in
‘files.el’.
(find-file-read-only FILENAME &optional WILDCARDS)
Edit file FILENAME but don’t allow changes.
Like <open>, but marks buffer as read-only.
Use C-x C-q to permit editing.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#35577: find-file-read-only docstring old
2019-05-05 7:21 bug#35577: find-file-read-only docstring old 積丹尼 Dan Jacobson
@ 2019-05-05 12:40 ` Noam Postavsky
2019-05-05 12:55 ` 積丹尼 Dan Jacobson
0 siblings, 1 reply; 5+ messages in thread
From: Noam Postavsky @ 2019-05-05 12:40 UTC (permalink / raw)
To: 積丹尼 Dan Jacobson; +Cc: 35577
積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
> "open"? Don't you mean find-file?:
If shows the binding of find-file. I guess you've removed the C-x C-f
binding so you the the <open> one (which appears to be for a Sun
keyboard).
bindings.el:
(define-key global-map [again] 'repeat-complex-command) ; Sun keyboard
(define-key global-map [open] 'find-file) ; Sun
> Like <open>, but marks buffer as read-only.
From 'emacs -Q' it says:
Like C-x C-f, but marks buffer as read-only.
> Use C-x C-q to permit editing.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#35577: find-file-read-only docstring old
2019-05-05 12:40 ` Noam Postavsky
@ 2019-05-05 12:55 ` 積丹尼 Dan Jacobson
2019-05-05 13:19 ` Noam Postavsky
0 siblings, 1 reply; 5+ messages in thread
From: 積丹尼 Dan Jacobson @ 2019-05-05 12:55 UTC (permalink / raw)
To: Noam Postavsky; +Cc: 35577
Oh, so that is a side effect of ffap-bindings. Hmmm.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#35577: find-file-read-only docstring old
2019-05-05 12:55 ` 積丹尼 Dan Jacobson
@ 2019-05-05 13:19 ` Noam Postavsky
2019-05-12 12:07 ` Noam Postavsky
0 siblings, 1 reply; 5+ messages in thread
From: Noam Postavsky @ 2019-05-05 13:19 UTC (permalink / raw)
To: 積丹尼 Dan Jacobson; +Cc: 35577
[-- Attachment #1: Type: text/plain, Size: 322 bytes --]
retitle 35577 ffap-commands causes find-file-read-only doc to display <open> for find-file
quit
積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:
> Oh, so that is a side effect of ffap-bindings. Hmmm.
Ah, I see. I think using [rename CMD] works better and fixes this case
(ido-mode uses this technique):
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 2474 bytes --]
From 0713b2d8ad3e75339c573354212602e661d314af Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sun, 5 May 2019 09:13:19 -0400
Subject: [PATCH] Use remapping in ffap-bindings (Bug#35577)
* lisp/ffap.el (ffap-bindings): Bind to the [remap COMMAND] instead of
hardcoding the default keybindings. This better adapts better if
non-default are used. And lets the original keybindings be
remembered, so that, e.g., \[find-file] in docstrings will still be
substituted with C-x C-f (even though that binding has been remapped
to find-file-at-point.
---
lisp/ffap.el | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/lisp/ffap.el b/lisp/ffap.el
index 36e37e95fe..bcb5efef54 100644
--- a/lisp/ffap.el
+++ b/lisp/ffap.el
@@ -2042,19 +2042,19 @@ (defvar ffap-bindings
'((global-set-key [S-mouse-3] 'ffap-at-mouse)
(global-set-key [C-S-mouse-3] 'ffap-menu)
- (global-set-key "\C-x\C-f" 'find-file-at-point)
- (global-set-key "\C-x\C-r" 'ffap-read-only)
- (global-set-key "\C-x\C-v" 'ffap-alternate-file)
-
- (global-set-key "\C-x4f" 'ffap-other-window)
- (global-set-key "\C-x5f" 'ffap-other-frame)
- (global-set-key "\C-x4r" 'ffap-read-only-other-window)
- (global-set-key "\C-x5r" 'ffap-read-only-other-frame)
-
- (global-set-key "\C-xd" 'dired-at-point)
- (global-set-key "\C-x4d" 'ffap-dired-other-window)
- (global-set-key "\C-x5d" 'ffap-dired-other-frame)
- (global-set-key "\C-x\C-d" 'ffap-list-directory)
+ (global-set-key [remap find-file] 'find-file-at-point)
+ (global-set-key [remap find-file-read-only] 'ffap-read-only)
+ (global-set-key [remap find-alternate-file] 'ffap-alternate-file)
+
+ (global-set-key [remap find-file-other-window] 'ffap-other-window)
+ (global-set-key [remap find-file-other-frame] 'ffap-other-frame)
+ (global-set-key [remap find-file-read-only-other-window] 'ffap-read-only-other-window)
+ (global-set-key [remap find-file-read-only-other-frame] 'ffap-read-only-other-frame)
+
+ (global-set-key [remap dired] 'dired-at-point)
+ (global-set-key [remap dired-other-window] 'ffap-dired-other-window)
+ (global-set-key [remap dired-other-frame] 'ffap-dired-other-frame)
+ (global-set-key [remap list-directory] 'ffap-list-directory)
(add-hook 'gnus-summary-mode-hook 'ffap-gnus-hook)
(add-hook 'gnus-article-mode-hook 'ffap-gnus-hook)
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#35577: find-file-read-only docstring old
2019-05-05 13:19 ` Noam Postavsky
@ 2019-05-12 12:07 ` Noam Postavsky
0 siblings, 0 replies; 5+ messages in thread
From: Noam Postavsky @ 2019-05-12 12:07 UTC (permalink / raw)
To: 積丹尼 Dan Jacobson; +Cc: 35577
tags 35577 fixed
close 35577 27.1
quit
>> Oh, so that is a side effect of ffap-bindings. Hmmm.
>
> Ah, I see. I think using [rename CMD] works better and fixes this case
> (ido-mode uses this technique)
Pushed to master.
b1cc876b6c 2019-05-12T08:05:01-04:00 "Use remapping in ffap-bindings (Bug#35577)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b1cc876b6c9d00cd9d9f4ed65176274bf35a81c4
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-12 12:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-05 7:21 bug#35577: find-file-read-only docstring old 積丹尼 Dan Jacobson
2019-05-05 12:40 ` Noam Postavsky
2019-05-05 12:55 ` 積丹尼 Dan Jacobson
2019-05-05 13:19 ` Noam Postavsky
2019-05-12 12:07 ` Noam Postavsky
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.