From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#35624: log-view-diff regression Date: Sun, 16 Jun 2019 23:13:17 +0300 Organization: LINKOV.NET Message-ID: <87fto98e5q.fsf@mail.linkov.net> References: <87pnou2ak2.fsf@mail.linkov.net> <9e4ac5c6-af62-f907-dc30-a85a1ba6bd23@yandex.ru> <87y33a3x6k.fsf@mail.linkov.net> <87bm04vky9.fsf@mail.linkov.net> <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> <87lfz7o05l.fsf@mail.linkov.net> <8c724814-923f-351a-686c-9f9c11468187@yandex.ru> <878sv6jhdm.fsf@mail.linkov.net> <8736laqk5e.fsf@mail.linkov.net> <5d7923e8-d39c-61cb-f1a6-fd9076fafae6@yandex.ru> <87lfyzy3c1.fsf@mail.linkov.net> <87y32zv6i6.fsf@mail.linkov.net> <87r28o3mnm.fsf@mail.linkov.net> <6b924be6-770e-a011-79c7-8278ff76005a@yandex.ru> <87v9xzd948.fsf@mail.linkov.net> <3b1817fd-6b81-2673-921f-b1e7c411203e@yandex.ru> <87tvdfem02.fsf@mail.linkov.net> <2f46c05d-a656-b791-dcec-cb705f6bf955@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="223927"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 35624@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 16 22:38:49 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcbvM-000w90-K0 for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Jun 2019 22:38:49 +0200 Original-Received: from localhost ([::1]:42766 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcbvL-0000QF-JS for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Jun 2019 16:38:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56576) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcbuf-0000P3-Ej for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2019 16:38:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcbue-00083Z-F8 for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2019 16:38:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56243) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcbuc-00082p-Cw for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2019 16:38:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hcbuc-0004QI-9r for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2019 16:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jun 2019 20:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35624 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35624-submit@debbugs.gnu.org id=B35624.156071743116922 (code B ref 35624); Sun, 16 Jun 2019 20:38:02 +0000 Original-Received: (at 35624) by debbugs.gnu.org; 16 Jun 2019 20:37:11 +0000 Original-Received: from localhost ([127.0.0.1]:41554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcbtn-0004Oq-1o for submit@debbugs.gnu.org; Sun, 16 Jun 2019 16:37:11 -0400 Original-Received: from egyptian.birch.relay.mailchannels.net ([23.83.209.56]:1038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcbtl-0004Oh-6W for 35624@debbugs.gnu.org; Sun, 16 Jun 2019 16:37:09 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 30702501AD9; Sun, 16 Jun 2019 20:37:08 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a70.g.dreamhost.com (100-96-14-97.trex.outbound.svc.cluster.local [100.96.14.97]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7FB10501A1F; Sun, 16 Jun 2019 20:37:07 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a70.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Sun, 16 Jun 2019 20:37:08 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Glossy-Shelf: 2461021c3c7c3605_1560717428025_3137893612 X-MC-Loop-Signature: 1560717428025:3406924462 X-MC-Ingress-Time: 1560717428024 Original-Received: from pdx1-sub0-mail-a70.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a70.g.dreamhost.com (Postfix) with ESMTP id 62D5681061; Sun, 16 Jun 2019 13:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=dQaS6duDmmHN3s40yyoBE94jPhg=; b= 0h800RWE+G0RexMdpldQHnl344zovuF1OOO/km1dj8E4+7PoROuZJsVmnLE6aLnC afvYgebG5aXatQyhIitawMgBlHDY2YCfhSngclIV56euq25o9lvHazM8FMuCBttX 9pso2sBq/d9TDFZMkfyLdM8a5bTW1jjLB5ay2NzZDdk= Original-Received: from mail.jurta.org (m91-129-109-209.cust.tele2.ee [91.129.109.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a70.g.dreamhost.com (Postfix) with ESMTPSA id 5C08481066; Sun, 16 Jun 2019 13:37:03 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a70 In-Reply-To: <2f46c05d-a656-b791-dcec-cb705f6bf955@yandex.ru> (Dmitry Gutov's message of "Sun, 16 Jun 2019 03:55:43 +0300") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddrudeihedgudehhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtledrvddtleenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdelrddvtdelpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgepfe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160699 Archived-At: >> The next step is to implement 'window-start-marker' in bug#35860, >> and set it to the second line, so after displaying the log buffer >> the first line will be off-screen. > > Speaking about this approach... What happens when the whole log buffer is > shorter than the window it's displayed in? It was difficult for me to test this case because I rely heavily on ediff for development, but ediff has been broken for a week in master. It makes sense to revert changes that break some function completely because currently ediff is unusable giving this error: Debugger entered--Lisp error: (void-function nil) nil(#("..." 39 51 (face (diff-file-header diff-header) fontified t)) (list (lambda nil (add-hook 'ediff-after-quit-hook-internal (lambda nil (if (ediff-buffer-live-p #) (ediff-show-meta-buffer # 1))) nil 'local) (setq ediff-meta-buffer # ediff-meta-session-number 1) (setq ediff-merge-store-file nil) (setcar '(nil nil (#("..." 39 51 ...) nil) (# nil) (# nil)) ediff-control-buffer)))) ediff-filegroup-action() funcall-interactively(ediff-filegroup-action) call-interactively(ediff-filegroup-action nil nil) command-execute(ediff-filegroup-action) But I tried to do ediff's work manually, and can confirm now that when the whole log buffer is shorter than the window then the patch from bug#35860 still works correctly hiding the first line initially.