From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#22457: 24.5; [PATCH] `dired-mark-if' should not count non-changes Date: Wed, 26 Jun 2019 01:02:47 +0200 Message-ID: <87ftnxmfoo.fsf@web.de> References: <2a6ff247-2b75-4f85-9a4c-889576ed7b34@default> <87o92lmgez.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="95732"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 22457@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 01:09:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfuYz-000OpB-3T for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 01:09:21 +0200 Original-Received: from localhost ([::1]:35682 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfuYx-0006Tv-F3 for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Jun 2019 19:09:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33157) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfuYi-0006Td-M1 for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 19:09:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfuYh-0002Xj-IC for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 19:09:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48520) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hfuYg-0002Wh-IZ for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 19:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hfuYg-0002he-CU for bug-gnu-emacs@gnu.org; Tue, 25 Jun 2019 19:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 23:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22457 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22457-submit@debbugs.gnu.org id=B22457.156150409110299 (code B ref 22457); Tue, 25 Jun 2019 23:09:02 +0000 Original-Received: (at 22457) by debbugs.gnu.org; 25 Jun 2019 23:08:11 +0000 Original-Received: from localhost ([127.0.0.1]:33827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuXr-0002g3-8M for submit@debbugs.gnu.org; Tue, 25 Jun 2019 19:08:11 -0400 Original-Received: from mout.web.de ([217.72.192.78]:47637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfuXp-0002fj-Gk for 22457@debbugs.gnu.org; Tue, 25 Jun 2019 19:08:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1561504082; bh=DaVRr7OQ8tlGgFYoVTcznUkMWkuvvaAuLbTNMsC79W8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=BxvN1m9QUMCwj8spdPqCwdEfvDfwOPoaRQ8LJ0gRedZVMCeyAHcl4nchDK+MoAcJB 6MsJbL14+y7FjTwRYNoF/7ZDNtNzlk7aELBtT+hG0PQiPK1bFnb2SoF5NCw9qDjJqi 0cHSjQSQm2Ay4FyiDOwJVgnEBFNgaBUzTiVBIQDE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([94.218.184.73]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MTh2S-1i6LJS1bii-00QSmS; Wed, 26 Jun 2019 01:02:50 +0200 In-Reply-To: (Lars Ingebrigtsen's message of "Wed, 26 Jun 2019 00:53:12 +0200") X-Provags-ID: V03:K1:Bj5HwRTpqQnHU54OLLb4oecMS9zeX1Tkzh7I5SON0LsEVw9W6On Eh3JyNO9MmmswCC4Oe0UfFknD7cGq3rQW5B2SnlOoHl9nRki6ehr5M9OCxXcmADQo419d7u gzl4glM6GxmfNYJU150O0ajmpBtMl/EOPhoOfYy2YbipgsljiEiDXBmVAJPAGkrI7mcqODc YJu0rhetjGYVyE6ynBCHg== X-UI-Out-Filterresults: notjunk:1;V03:K0:tI3pL4qUkf4=:fJxUnvFu/N8RDjpsMx73sI L0t9f/yEcqsqQSYoTJpXkf9dzdOUBeDITxxAEi9+d0DES9+QrxJ0oR5PBWPtewIX1gv4qabq5 gEb/NC1y6PjsyYvMV/y7+FEfohKQkjGpl8Ike/AL2zfPjd6kdeyCJxOf+l159gMWB7+Ksq5sf ns/OmzmFrtVlAnh27Qa41YhAbeQscnBgqg72vPbByKUslnK/Nf8lwmYZQU9mbcdMz1bXujpoQ 7IFz+o5d4JsyuySSOVWIP59Na2dWJftD7ZjBMI9xXMIrRFOX66wJ825SEunyoZBjbV+9R1u9Z XFaNcbrlONaSIp0bfs9QjJKbj1Edb/aMwm59Pe5RokrZIHgfx4Tx1thf9SniCutWlI6FgSVRD xAy79qy6N0b+ULVIi3TR1zEX1hW0ccp2CyXB6dlbsqSQb94fnztXO+usnxhoV3WaHvaAVApS9 RRmv+ySqjG+sfl+b9upjH0oyJ4ktJu2v62DTv37woCeLTROCFLEn50pKQfHXfyr7TgUL07sun LV8uKIuFL2EBbeQ4hQb3wZcn3t5nW9m3a/uKkwv5uEcQN9GscpB4XJ/2JSNYjxsWmYOgl+8UW oqymdW/SuOCql6cFdPhW76yhOAwT2vuhh5pFPwz4p5Zoz/bKmJVHDpuJksOmBVRz2BL8hHtsV ruBD/6teqRv7ZhAVXleHB6WVJ5Dw+y2ItdfYJh35N0pvGAPxm1Laq3SGgxx0NOf2jnDecvlAf flzpnO+n/FJyamCjfyHwErajZSLGgbVg69rOPSnBHwiDDTpS+/njsIaogot9hXxvrxYgHiB2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161441 Archived-At: Lars Ingebrigtsen writes: > > I don't think this exactly describes what the patch changed: it is not > > about new vs total marks, but about marks of files that were already > > marked before, right? > > It's this code: > > (unless (looking-at-p (char-to-string dired-marker-char)) > (delete-char 1) > (insert dired-marker-char) > (setq count (1+ count)))) > > So now it says how many lines that are marked this time. Previously it > gave you a total tally of all marked files. Yes, I think I understand. My problem is that "[...] not how many files are marked in total" sounds like as if marked files that were not even touched by the command (that are not matched by the predicate) were previously included. You mean it relative to the files matched, right? Oh, btw, this patch line (looking-at-p (char-to-string dired-marker-char)) is not good if dired-marker-char is a regexp special like . or ?, I guess (regexp-quote missing)? Michael