From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#25764: 26.0.50; Make some usability improvements to sieve-script management Date: Tue, 09 Jul 2019 01:50:38 +0100 Message-ID: <87ftngdo9t.fsf@tcd.ie> References: <87vas9rg8q.fsf@ericabrahamsen.net> <87o924l0l0.fsf@tcd.ie> <87tvbw13vl.fsf@ericabrahamsen.net> <87imsc12xv.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256506"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 25764@debbugs.gnu.org To: Eric Abrahamsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 09 02:51:39 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkeM4-0014Ym-B6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 09 Jul 2019 02:51:36 +0200 Original-Received: from localhost ([::1]:45892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkeM3-0003aK-Be for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jul 2019 20:51:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51832) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkeLY-0003V1-SD for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 20:51:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkeLX-0000le-IU for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 20:51:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51213) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hkeLW-0000lB-4X for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 20:51:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hkeLV-0001Po-UR for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2019 20:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jul 2019 00:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25764 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25764-submit@debbugs.gnu.org id=B25764.15626334495424 (code B ref 25764); Tue, 09 Jul 2019 00:51:01 +0000 Original-Received: (at 25764) by debbugs.gnu.org; 9 Jul 2019 00:50:49 +0000 Original-Received: from localhost ([127.0.0.1]:60034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkeLI-0001PP-Rg for submit@debbugs.gnu.org; Mon, 08 Jul 2019 20:50:49 -0400 Original-Received: from mail-wm1-f66.google.com ([209.85.128.66]:33585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hkeLG-0001PB-CC for 25764@debbugs.gnu.org; Mon, 08 Jul 2019 20:50:47 -0400 Original-Received: by mail-wm1-f66.google.com with SMTP id h19so1180433wme.0 for <25764@debbugs.gnu.org>; Mon, 08 Jul 2019 17:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=oyYZ+PGMoyliWCp5YbKrG4adZCZhCWB6Xnve89yPe3Q=; b=r/O4w7pjvtvZnbCxyiAQoVSK5vTZY9OXkchHwT3PWbYjN3Znla+WIn41cHKXu58uO6 HYT/RdH0AJMwW3owcd+5oue5zGCtOjQ7o2a7VOjf5c+zCjQj2yDgaZasHnEaK1JXvR52 cHmxnygG3RtDpNROGB0z0HNxw6+Z/dMfSsSVsz10q6RkJbvPfvgbBdNxLmwJLVxEV9SX JWWA1N2AHWVyo12eLa4VskfDBbDVVuwULBaOsKdeJkIJh5KAOOrzDaok9hMASMRY6jMk xKTu3KpKLS7AUCvKnxP860ETC5u5R1svCjTYV0p9GOU2CopD5hFwLOFwH3Rj+hhbzYe+ Q51w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=oyYZ+PGMoyliWCp5YbKrG4adZCZhCWB6Xnve89yPe3Q=; b=cRc/k5Jl4Z8TyD5+V5+B7vdPQ1XSSp8uGjqsz4zDK6gq+ovtxSeh8pJCn21iWwFGjB QD/VExvvixArqNvJhcC+ruTIBNvM/qmky5Jz2kv4ww2hqHWRX27wYSkPPvQumxLm9JAJ kzXF9ZSFsQdSWqQ2fETB7VSWgIahrQ9bwiuG6Z3EVLYUtjrBKAKjMkFZ2OwhFB35XUoP OXNVbZ7DZ/oBHdyGGVyG0dOIipfGhFzg8JI0lPyNZrZOTLH0LraAVKFeBZDgsDIZlbhA 1nI9NxKKMBkKCLzn1e8+rDulqvGWv6ApQWJ2T6SOciuglpY4xIVIh5NrRdWI8u9u+Nwn h9DQ== X-Gm-Message-State: APjAAAVIqDvJI78K/x9u8S1Ao7z9UXoNxADHutln900W5uV9pvwNWVOP E1fBb3tPCcDXo0arZNZh5An0XQ== X-Google-Smtp-Source: APXvYqzb1StUa3lytZSgKxjeZ/y65Gj07eVZZGdjBGWFqKw2870GHcHvZstfuyds/PEgFiJiJKMpGw== X-Received: by 2002:a1c:4d05:: with SMTP id o5mr18273109wmh.63.1562633439812; Mon, 08 Jul 2019 17:50:39 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id r12sm29898875wrt.95.2019.07.08.17.50.39 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 08 Jul 2019 17:50:39 -0700 (PDT) In-Reply-To: <87imsc12xv.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 08 Jul 2019 17:12:12 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162415 Archived-At: Eric Abrahamsen writes: > Lars Ingebrigtsen writes: > >> Eric Abrahamsen writes: >> >>> I do use sieve! But I didn't write this code. I know, just thought I may as well fix these trivial instances upon seeing your patch. >>> Your proposed chances seem fine to me, though I'm wondering about >>> the use of `ngettext' -- I saw some arguments on these lists >>> recently about international/localization, and wasn't paying too >>> much attention, but didn't see a clear resolution. Is it the >>> consensus that we're supposed to be using `ngettext' where possible? >> >> Oh, I didn't notice that part. No, I don't think there's any such >> consensus... > > There are 23 uses of `ngettext' in the sources right now, which says to > me: "there's no consensus, but it's also not a problem". That's more or less my understanding as well: [45c525a685]: Fig grammar of count-lines-page 2019-06-09 17:00:05 -0700 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=45c525a685041c274a26c70caed4088726a790de [7bba702e1a]: Use ngettext instead of dired-plural-s in Dired (bug#35287) 2019-05-05 22:43:27 +0300 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=7bba702e1ad1ed343618e44cf5bbc2a1f079be0c I wasn't involved in the discussion, but IIRC l10n (i.e. using a no-op ngettext for now) is welcome and encouraged, it's just that we don't have an agreed upon or concrete implementation yet. I think it's definitely better to mark the text as localisable now, while we're in the area, than leave the previous string formatting trick for future archaeologists to rediscover. So I've now pushed my patch: [7b70efb740]: Tidy up sieve.el text formatting 2019-07-09 01:47:52 +0100 https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=7b70efb740a04517e2764b0986c6e92305c1dd3e Thanks for the review and sorry for hijacking this report. -- Basil