all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 25764@debbugs.gnu.org
Subject: bug#25764: 26.0.50; Make some usability improvements to sieve-script management
Date: Tue, 09 Jul 2019 01:50:38 +0100	[thread overview]
Message-ID: <87ftngdo9t.fsf@tcd.ie> (raw)
In-Reply-To: <87imsc12xv.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 08 Jul 2019 17:12:12 -0700")

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>
>>> I do use sieve! But I didn't write this code.

I know, just thought I may as well fix these trivial instances upon
seeing your patch.

>>> Your proposed chances seem fine to me, though I'm wondering about
>>> the use of `ngettext' -- I saw some arguments on these lists
>>> recently about international/localization, and wasn't paying too
>>> much attention, but didn't see a clear resolution.  Is it the
>>> consensus that we're supposed to be using `ngettext' where possible?
>>
>> Oh, I didn't notice that part.  No, I don't think there's any such
>> consensus...
>
> There are 23 uses of `ngettext' in the sources right now, which says to
> me: "there's no consensus, but it's also not a problem".

That's more or less my understanding as well:

[45c525a685]: Fig grammar of count-lines-page
  2019-06-09 17:00:05 -0700
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=45c525a685041c274a26c70caed4088726a790de

[7bba702e1a]: Use ngettext instead of dired-plural-s in Dired (bug#35287)
  2019-05-05 22:43:27 +0300
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=7bba702e1ad1ed343618e44cf5bbc2a1f079be0c

I wasn't involved in the discussion, but IIRC l10n (i.e. using a no-op
ngettext for now) is welcome and encouraged, it's just that we don't
have an agreed upon or concrete implementation yet.  I think it's
definitely better to mark the text as localisable now, while we're in
the area, than leave the previous string formatting trick for future
archaeologists to rediscover.  So I've now pushed my patch:

[7b70efb740]: Tidy up sieve.el text formatting
  2019-07-09 01:47:52 +0100
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=7b70efb740a04517e2764b0986c6e92305c1dd3e

Thanks for the review and sorry for hijacking this report.

-- 
Basil





  reply	other threads:[~2019-07-09  0:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 21:13 bug#25764: 26.0.50; Make some usability improvements to sieve-script management Eric Abrahamsen
2019-06-24 23:03 ` Lars Ingebrigtsen
2019-07-08 17:55   ` Eric Abrahamsen
2019-07-08 20:42 ` Basil L. Contovounesios
2019-07-08 22:09   ` Lars Ingebrigtsen
2019-07-08 23:51   ` Eric Abrahamsen
2019-07-08 23:55     ` Lars Ingebrigtsen
2019-07-09  0:12       ` Eric Abrahamsen
2019-07-09  0:50         ` Basil L. Contovounesios [this message]
2019-07-09  1:06           ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftngdo9t.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=25764@debbugs.gnu.org \
    --cc=eric@ericabrahamsen.net \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.