From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#23455: 25.0.93; profiler-report doesn't configure xref for elisp Date: Sun, 28 Jul 2019 16:38:55 +0200 Message-ID: <87ftmqb4w0.fsf@mouse.gnus.org> References: <87oa8li7cu.wl-jch@pps.univ-paris-diderot.fr> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="243668"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 23455@debbugs.gnu.org To: Juliusz Chroboczek Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 28 16:40:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrkLJ-0011GG-2H for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 16:40:09 +0200 Original-Received: from localhost ([::1]:45464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrkLI-0004Oi-0Q for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Jul 2019 10:40:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46284) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrkLD-0004OK-CO for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:40:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrkLC-000481-89 for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38127) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrkLC-00047v-4U for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrkLC-00026h-03 for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2019 10:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2019 14:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23455 X-GNU-PR-Package: emacs Original-Received: via spool by 23455-submit@debbugs.gnu.org id=B23455.15643247427985 (code B ref 23455); Sun, 28 Jul 2019 14:40:01 +0000 Original-Received: (at 23455) by debbugs.gnu.org; 28 Jul 2019 14:39:02 +0000 Original-Received: from localhost ([127.0.0.1]:46945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrkKD-00024Y-Kg for submit@debbugs.gnu.org; Sun, 28 Jul 2019 10:39:01 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrkKB-00024I-K2 for 23455@debbugs.gnu.org; Sun, 28 Jul 2019 10:39:00 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrkK7-0004q3-NY; Sun, 28 Jul 2019 16:38:58 +0200 In-Reply-To: <87oa8li7cu.wl-jch@pps.univ-paris-diderot.fr> (Juliusz Chroboczek's message of "Thu, 05 May 2016 04:09:05 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163962 Archived-At: Juliusz Chroboczek writes: > Pressing M-. in the buffer generated by profiler-report prompts me for > a TAGS file rather than behaving like it does in an elisp buffer. (I'm going through old Emacs bug reports that haven't received any response.) The following patch seems to make `M-.' work as expected in the report buffers, but I'm wholly unfamiliar with how xref works -- I just cargo-culted the code in elisp-mode.el. Perhaps somebody who knows how this works can say whether it looks OK: diff --git a/lisp/profiler.el b/lisp/profiler.el index ee11ff68c5..92495e2de8 100644 --- a/lisp/profiler.el +++ b/lisp/profiler.el @@ -615,9 +615,12 @@ profiler-report-setup-buffer (profiler-report-render-calltree)) buffer)) +(defun profiler--xref-backend () 'elisp) + (define-derived-mode profiler-report-mode special-mode "Profiler-Report" "Profiler Report Mode." (add-to-invisibility-spec '(profiler . t)) + (add-hook 'xref-backend-functions #'profiler--xref-backend nil t) (setq buffer-read-only t buffer-undo-list t truncate-lines t)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no