From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 20164@debbugs.gnu.org
Subject: bug#20164: 25.0.50; Do not tell users that `x-show-tip' is internal
Date: Fri, 02 Aug 2019 14:28:45 +0200 [thread overview]
Message-ID: <87ftmjrbsy.fsf@mouse.gnus.org> (raw)
In-Reply-To: <7d0f8249-d653-40f9-8534-9ffe29d689a2@default> (Drew Adams's message of "Sun, 22 Mar 2015 09:40:22 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
> The doc string says this:
>
> This is an internal function; Lisp code should call `tooltip-show'.
>
> Why? While it is true that you can get, using `tooltip-show', the
> behavior of arg PARMS by binding `tooltip-frame-parameters', the behavior
> of args DX and DY by binding `tooltip-x-offset' and `tooltip-y-offset',
> and the behavior of arg TIMEOUT by binding `tooltip-hide-delay' (which is
> not documented, BTW), you cannot the behavior of arg FRAME. And binding
> user options is not really a great way to control the function behavior,
> in general.
I agree that the calling conventions for `x-show-tip' seems to be much
nicer than `tooltip-show'.
> So `tooltip-show' is not really a user-level substitute for "internal"
> `x-tooltip-show'.
>
> What's more, the doc of `tooltip-show' explicitly refers to how variable
> `x-max-tooltip-size' affects the behavior. Why refer to that "internal"
> variable? And if it is not "internal" then why does it have the prefix
> `x-'? Why isn't there a `tooltip-max-size' option, corresponding to the
> other `tooltip-*' options?
The commit that added the line about it being internal just says "doc
fix", so I can only guess what the reason behind it was: Perhaps we're
trying to get away from all `x-' functions and replace them with generic
functions? But, as you say, then it's odd that we still have
`x-max-tooltip-size'.
So perhaps the way forward here is to make `x-max-tooltip-size' an
obsolete alias for a new variable `tooltip-max-size'? And add a way to
specify the FRAME parameter somehow... but the calling convention for
that function is kinda meh.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-08-02 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-22 16:40 bug#20164: 25.0.50; Do not tell users that `x-show-tip' is internal Drew Adams
2019-08-02 12:28 ` Lars Ingebrigtsen [this message]
2019-08-02 14:20 ` Eli Zaretskii
2019-08-02 18:03 ` Lars Ingebrigtsen
2019-08-02 18:57 ` Eli Zaretskii
2019-08-02 15:38 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftmjrbsy.fsf@mouse.gnus.org \
--to=larsi@gnus.org \
--cc=20164@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.