From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#14502: 24.3; dired-load-hook should not be customizable Date: Fri, 16 Aug 2019 13:50:23 -0700 Message-ID: <87ftm0q1gw.fsf@mouse.gnus.org> References: <87k3mirl7x.fsf@sc3d.org> <8736i32g5y.fsf@mouse.gnus.org> <871rxlsxs3.fsf@mouse.gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="119998"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 14502@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 16 22:51:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyjBm-000V6H-Kc for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 22:51:10 +0200 Original-Received: from localhost ([::1]:59826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyjBl-0008OO-69 for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 16:51:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56592) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hyjBf-0008OB-5Z for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 16:51:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hyjBe-0005oO-1h for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 16:51:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46151) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hyjBd-0005oK-VE for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 16:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hyjBd-0002Ms-T9 for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 16:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2019 20:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14502 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 14502-submit@debbugs.gnu.org id=B14502.15659886379062 (code B ref 14502); Fri, 16 Aug 2019 20:51:01 +0000 Original-Received: (at 14502) by debbugs.gnu.org; 16 Aug 2019 20:50:37 +0000 Original-Received: from localhost ([127.0.0.1]:54972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjBE-0002M6-LP for submit@debbugs.gnu.org; Fri, 16 Aug 2019 16:50:36 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:37728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hyjBA-0002Lf-6H for 14502@debbugs.gnu.org; Fri, 16 Aug 2019 16:50:32 -0400 Original-Received: from [50.225.213.182] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hyjB5-0000ge-8U; Fri, 16 Aug 2019 22:50:30 +0200 In-Reply-To: (Reuben Thomas's message of "Fri, 16 Aug 2019 09:13:31 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165227 Archived-At: Reuben Thomas writes: > dired-x adds dired-extra-startup to dired-mode-hook=E2=80=A6 I missed that bit. > dired-mode-hook in my setup also has sml/set-buffer-identification added = by > smart-mode-line, so yes, it is "one of those hooks" It seems rather unsatisfactory to have to make a decision between "one of those hooks" and "the rest of the hooks" on a hook by hook basis... Stefan wrote in 2013: > So until Custom is fixed to actually properly handle customisation of > hooks (e.g. by storing "add functions foo, bar, and baz" rather than > "ignore current value and just set it to (foo bar baz)"). So I wondered what it would take to fix this in Customize properly. But: (define-widget 'hook 'list "An Emacs Lisp hook." [...] :set (lambda (symbol value) (dolist (elt value) (if (fboundp elt) (add-hook symbol elt)))) The :set action for hooks doesn't just overwrite the value, but uses `add-hook' the proper way? Now I'm even more confused. Hm... Perhaps that's not the code that's used when actually restoring hook values? Let's see. (defun customize-set-variable (variable value &optional comment) [...] (funcall (or (get variable 'custom-set) #'set-default) variable value) (get 'gnus-load-hook 'custom-set) =3D> nil So the setter is not used? Hm... Oh, it's only set if you say (defcustom ... :set ...) Right. So the :set in the widget is only used interactively? *tests* Nope, if I try to modify a hook in a Customize buffer, then it always overwrites the hook value. So, as usual, when trying to figure out how Customize works, it's... just... rather obscure. But I think one (probably controversial solution) would be to add a `custom-set' property on all hook variables that would make it use `add-hook' instead of just overwriting the value. That would make Customize and add-hook coexist... but would also mean that you can't set a hook to a specific value with Customize, which will probably break something for somebody. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no