From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#37073: 26.2.90; query-replace-regexp undo feature missing quote the regexps Date: Mon, 19 Aug 2019 00:06:20 +0300 Organization: LINKOV.NET Message-ID: <87ftlygpb7.fsf@mail.linkov.net> References: <87h86elgdr.fsf@calancha-pc.dy.bbexcite.jp> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="145093"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 37073@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 18 23:11:31 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hzSSY-000bVe-FU for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 23:11:30 +0200 Original-Received: from localhost ([::1]:42916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzSSW-0007OZ-Lg for geb-bug-gnu-emacs@m.gmane.org; Sun, 18 Aug 2019 17:11:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37245) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hzSS7-0007Mt-DA for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 17:11:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hzSS6-0007sy-Ee for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 17:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50021) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hzSS6-0007sq-BY for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 17:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hzSS6-0003sq-5L for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2019 17:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Aug 2019 21:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37073 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37073-submit@debbugs.gnu.org id=B37073.156616261814862 (code B ref 37073); Sun, 18 Aug 2019 21:11:02 +0000 Original-Received: (at 37073) by debbugs.gnu.org; 18 Aug 2019 21:10:18 +0000 Original-Received: from localhost ([127.0.0.1]:58838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzSRN-0003rd-Sf for submit@debbugs.gnu.org; Sun, 18 Aug 2019 17:10:18 -0400 Original-Received: from camel.birch.relay.mailchannels.net ([23.83.209.29]:26569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hzSRL-0003rP-NY for 37073@debbugs.gnu.org; Sun, 18 Aug 2019 17:10:16 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A10002C1DB1; Sun, 18 Aug 2019 21:10:14 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a11.g.dreamhost.com (100-96-35-20.trex.outbound.svc.cluster.local [100.96.35.20]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 101C82C27FC; Sun, 18 Aug 2019 21:10:14 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a11.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Sun, 18 Aug 2019 21:10:14 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Cooperative-Shelf: 446f107647eca5ca_1566162614470_1118977026 X-MC-Loop-Signature: 1566162614470:3104855986 X-MC-Ingress-Time: 1566162614470 Original-Received: from pdx1-sub0-mail-a11.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a11.g.dreamhost.com (Postfix) with ESMTP id 16CC783CDF; Sun, 18 Aug 2019 14:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=JvrAzvaS/7nneK3mQjpjF/hMfU8=; b= d7RO+oQumY8zseZEJFoxestBQTH4tD9bgluGuCwNFVCGvzP5axZo8P2u0I3pP6K0 ksjXQ6xisAHK3wU+UVBjC2xJHSVLK1+GWzlM01TGzYajmUjdInzb3dn7iYpe7+XZ yieEWhPpur4OFkVShPBkL7Xzr0/4gllJf1+D2znPmuU= Original-Received: from mail.jurta.org (m91-129-109-163.cust.tele2.ee [91.129.109.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a11.g.dreamhost.com (Postfix) with ESMTPSA id 7F99683CEA; Sun, 18 Aug 2019 14:10:08 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a11 In-Reply-To: <87h86elgdr.fsf@calancha-pc.dy.bbexcite.jp> (Tino Calancha's message of "Sun, 18 Aug 2019 16:04:00 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrudefjedgudehiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtledrudeifeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdelrdduieefpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepthhinhhordgtrghlrghntghhrgesghhmrghilhdrtghomhenucevlhhushhtvghrufhiiigvpedu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165356 Archived-At: > That causes the undo feature to fail if the replacement contains special characters. Thanks. Are there other looking-at/looking-back occurrences in perform-replace that are looking at non-regexp strings? > commit 9f9c56cfa99b1e6fe296ec591ab335521e185e55 > Author: Tino Calancha > Date: Sun Aug 18 15:57:59 2019 +0200 > > Fix query-replace-regexp undo feature > > * lisp/replace.el (perform-replace): Quote regexp (Bug#37073). > * test/lisp/replace-tests.el (query-replace-undo-bug37073): Add test This looks good, but please ask Eli about pushing it to emacs-26 branch. Recently we fixed another problem exactly in the same place, but pushed the fix to the master.