From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24213: 25.1.50; Fishy use of delete-window in register.el Date: Sun, 29 Sep 2019 16:58:37 +0200 Message-ID: <87ftkfgndu.fsf@gnus.org> References: <87mvkhivpu.fsf@hochschule-trier.de> <57AED93A.4090902@gmx.at> <878tw1kqby.fsf@hochschule-trier.de> <57AEF063.6070907@gmx.at> <8760qg69q3.fsf@hochschule-trier.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="52528"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 24213@debbugs.gnu.org To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 29 16:59:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEafK-000DWw-Hl for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Sep 2019 16:59:14 +0200 Original-Received: from localhost ([::1]:40030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEafI-0005gB-UZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Sep 2019 10:59:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44294) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iEafA-0005fx-Gh for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 10:59:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iEaf9-0004s0-4E for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 10:59:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46618) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iEaf9-0004rv-0x for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 10:59:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iEaf8-00039I-Iy for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2019 10:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2019 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24213 X-GNU-PR-Package: emacs Original-Received: via spool by 24213-submit@debbugs.gnu.org id=B24213.156976912412068 (code B ref 24213); Sun, 29 Sep 2019 14:59:02 +0000 Original-Received: (at 24213) by debbugs.gnu.org; 29 Sep 2019 14:58:44 +0000 Original-Received: from localhost ([127.0.0.1]:55436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEaeq-00038a-70 for submit@debbugs.gnu.org; Sun, 29 Sep 2019 10:58:44 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEaeo-00038P-2l for 24213@debbugs.gnu.org; Sun, 29 Sep 2019 10:58:42 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEaej-00027e-G6; Sun, 29 Sep 2019 16:58:39 +0200 In-Reply-To: <8760qg69q3.fsf@hochschule-trier.de> (Andreas Politz's message of "Wed, 31 Aug 2016 21:04:36 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167687 Archived-At: Andreas Politz writes: > I finally got around to this. The changes in the following diff seem to > be all clear cut cases, where the window is created by > display-buffer/pop-to-buffer without any special window-handling logic > attached. Let me know what you think. Apparently the patch was not applied at the time, and many of the instances have later been fixed. I've respun the patch for Emacs 27, and the remaining fixups (replacing delete-window with quit-window look logical to me. Does anybody have any comments? diff --git a/lisp/progmodes/idlwave.el b/lisp/progmodes/idlwave.el index 1b4b55c94f..3535a7b4aa 100644 --- a/lisp/progmodes/idlwave.el +++ b/lisp/progmodes/idlwave.el @@ -8271,7 +8271,7 @@ idlwave-quit-help (select-window olh-window) (idlwave-help-quit)) (when (window-live-p ri-window) - (delete-window ri-window)))) + (quit-window nil ri-window)))) (defun idlwave-display-calling-sequence (name type class &optional initial-class) diff --git a/lisp/progmodes/verilog-mode.el b/lisp/progmodes/verilog-mode.el index baeaf8b95d..5bfa5f837a 100644 --- a/lisp/progmodes/verilog-mode.el +++ b/lisp/progmodes/verilog-mode.el @@ -7598,8 +7598,7 @@ verilog-complete-word (display-completion-list allcomp)) ;; Wait for a key press. Then delete *Completion* window (momentary-string-display "" (point)) - (delete-window (get-buffer-window (get-buffer "*Completions*"))) - ))))) + (quit-window nil (get-buffer-window "*Completions*"))))))) (defun verilog-show-completions () "Show all possible completions at current point." @@ -7611,7 +7610,8 @@ verilog-show-completions (display-completion-list (nth 2 (verilog-completion-at-point)))) ;; Wait for a key press. Then delete *Completion* window (momentary-string-display "" (point)) - (delete-window (get-buffer-window (get-buffer "*Completions*")))) + (quit-window nil (get-buffer-window "*Completions*"))) + (defun verilog-get-default-symbol () "Return symbol around current point as a string." diff --git a/lisp/startup.el b/lisp/startup.el index 52d4dbb05c..7eb0180d41 100644 --- a/lisp/startup.el +++ b/lisp/startup.el @@ -1853,9 +1853,7 @@ fancy-startup-tail (customize-set-variable 'inhibit-startup-screen t) (customize-mark-to-save 'inhibit-startup-screen) (custom-save-all)) - (let ((w (get-buffer-window "*GNU Emacs*"))) - (and w (not (one-window-p)) (delete-window w))) - (kill-buffer "*GNU Emacs*"))) + (quit-windows-on "*GNU Emacs*" t))) " ") (when (or user-init-file custom-file) (let ((checked (create-image "checked.xpm" diff --git a/lisp/strokes.el b/lisp/strokes.el index 6edf58c7b6..2c88b1eefd 100644 --- a/lisp/strokes.el +++ b/lisp/strokes.el @@ -1216,9 +1216,7 @@ strokes-xpm-for-stroke ;;(defun strokes-edit-quit () ;; (interactive) -;; (or (one-window-p t 0) -;; (delete-window)) -;; (kill-buffer "*Strokes List*")) +;; (quit-windows-on "*Strokes List*" t)) ;;(define-derived-mode edit-strokes-mode list-mode ;; "Edit-Strokes" -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no