From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el from previous change
Date: Thu, 03 Oct 2019 17:18:51 +0200 [thread overview]
Message-ID: <87ftk9svqc.fsf@gnus.org> (raw)
In-Reply-To: <jwvv9t84dhk.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 01 Oct 2019 17:30:38 -0400")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> I'm not quite sure I followed the last bit -- if something transitively
>> required cl-lib, then there's no point for the "top" file to require
>> cl-lib, surely? Or is this a style issue.
>
> If a file (transitively) required by bytecomp.el requires cl-lib,
> then when compiling *another* file any missing (require 'cl-lib) in that
> other file won't be noticed.
Oh, this is just special for bytecomp.el; I get it.
>> (defvar emacs-lisp-compilation-mode-map
>> (let ((map (make-sparse-keymap)))
>> (set-keymap-parent map compilation-minor-mode-map)
>> (define-key map "g" 'emacs-lisp-compilation-recompile)
>> map))
>
> Do we need this set-keymap-parent? define-derived-mode should do it for
> us (when the mode is called).
I didn't know that. I've now made the change (and reverted the
`require'), and this do indeed work as they should.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-10-03 15:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191001144135.32717.19241@vcs0.savannah.gnu.org>
[not found] ` <20191001144137.1032C20927@vcs0.savannah.gnu.org>
2019-10-01 15:08 ` [Emacs-diffs] master 28b7dd4 2/2: Fix build error in bytecomp.el from previous change Stefan Monnier
2019-10-01 15:22 ` Lars Ingebrigtsen
2019-10-01 21:30 ` Stefan Monnier
2019-10-03 15:18 ` Lars Ingebrigtsen [this message]
2019-10-02 16:57 ` Sven Joachim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftk9svqc.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.