From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Wed, 27 Nov 2019 01:06:39 +0200 Organization: LINKOV.NET Message-ID: <87ftia1bls.fsf@mail.linkov.net> References: <87ftj5at1q.fsf@gnus.org> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <87d0di7959.fsf@linkov.net> <7115df2d-c209-c672-7e92-ff682c4ec8ee@yandex.ru> <87mucm43ja.fsf@mail.linkov.net> <6d316d96-0c2b-27e8-f538-a7909a127b7a@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="200272"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: stephen.berman@gmx.net, 38044@debbugs.gnu.org, larsi@gnus.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 27 00:22:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZk9x-000pyJ-Fi for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Nov 2019 00:22:17 +0100 Original-Received: from localhost ([::1]:60036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZk9w-0004n7-An for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 18:22:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34812) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZk8m-0003zd-TW for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 18:21:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZk8l-0002G9-Qk for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 18:21:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47204) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZk8l-0002Ft-AR for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 18:21:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZk8l-0001tp-7f for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 18:21:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2019 23:21:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.15748104197181 (code B ref 38044); Tue, 26 Nov 2019 23:21:03 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 26 Nov 2019 23:20:19 +0000 Original-Received: from localhost ([127.0.0.1]:53169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZk83-0001rk-B5 for submit@debbugs.gnu.org; Tue, 26 Nov 2019 18:20:19 -0500 Original-Received: from egyptian.birch.relay.mailchannels.net ([23.83.209.56]:19165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZk82-0001rc-2G for 38044@debbugs.gnu.org; Tue, 26 Nov 2019 18:20:18 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E3B84581258; Tue, 26 Nov 2019 23:20:16 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a89.g.dreamhost.com (100-96-45-206.trex.outbound.svc.cluster.local [100.96.45.206]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 705AC5811D3; Tue, 26 Nov 2019 23:20:16 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a89.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Tue, 26 Nov 2019 23:20:16 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Zesty-Shrill: 005617c57e140aa4_1574810416721_285082451 X-MC-Loop-Signature: 1574810416721:1648870321 X-MC-Ingress-Time: 1574810416720 Original-Received: from pdx1-sub0-mail-a89.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a89.g.dreamhost.com (Postfix) with ESMTP id 49111A415E; Tue, 26 Nov 2019 15:20:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=5ia6ofciffiVp06BwoVzM0qqncM=; b= iRnjKXalnflK0OCBXQI3ob0ooOCM472FUZJBgsDQ0efc6qiYPze6EZksAF2Sq81O MmUmtVAjV283ouXJc5a5w7e6FmxhGSdfCn4S/6C0iLtectHdIpGL5S/eOv+9ILV2 4ule7IIEvxiCAf77qN01Nn4zNR3J6qLwIMriVKJVQyc= Original-Received: from mail.jurta.org (m91-129-96-42.cust.tele2.ee [91.129.96.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a89.g.dreamhost.com (Postfix) with ESMTPSA id A8F39A415F; Tue, 26 Nov 2019 15:20:07 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a89 In-Reply-To: <6d316d96-0c2b-27e8-f538-a7909a127b7a@yandex.ru> (Dmitry Gutov's message of "Mon, 25 Nov 2019 02:12:42 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172504 Archived-At: >> I rewrote the patch to make it more flexible, so now the function >> can check 'vc-log-view-type' for the value 'with-diff'. > > Generally, an explicit argument is better than an implicit one. > > So what's the idea here? Gracefully degrading to just showing a log entry > when the backend doesn't support the WITH-DIFF feature? Yes, if a backend doesn't support WITH-DIFF, then do nothing special. > (BTW, the print-revision approach seems better for graceful > degradation, but I'm tired of arguing for that). The print-log approach is not bad too: 'C-1 C-x v L' is mnemonic ("show me just 1 revision") and easy to type. > I think it would work, but for that all backends need support for > region-history-mode anyway. The caller function doesn't have a way to > check the lack of support. The new patch I sent now in another message checks if a backend supports region-history-mode.