From: Juri Linkov <juri@linkov.net>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: 38111@debbugs.gnu.org
Subject: bug#38111: 27.0.50; globalized-minor-mode not enabled on get-buffer-create
Date: Sun, 08 Dec 2019 00:56:00 +0200 [thread overview]
Message-ID: <87fthvhhj3.fsf@mail.linkov.net> (raw)
In-Reply-To: <b7a4b75aa812be3d838ca95975686a61@webmail.orcon.net.nz> (Phil Sainty's message of "Wed, 13 Nov 2019 11:42:07 +1300")
reopen 38111
tags 38111 - notabug
quit
>> Sounds like globalized-minor-mode machinery somehow doesn't support
>> the latter method of creating a buffer?
>
> Yep, globalized modes use `after-change-major-mode-hook' to call the
> buffer-local minor mode, and that hook is not triggered in these cases
> because, although new buffers are in `fundamental-mode' by default,
> the `fundamental-mode' function is not actually called, and so no mode
> change occurs.
>
> I believe this has cropped up in past discussion, but I don't recall
> where offhand.
>
> I agree that it's surprising when you are expecting the global mode(s)
> to be enabled (I first realised it when attempting to use a globalized
> mode for my custom key bindings, and discovering they were not being
> enabled in various buffers).
>
> If this were changed then there *might* be undesirable consequences to
> having lots of created-behind-the-scenes buffers suddenly doing things
> they never did before.
Actually that turned out to be a problem in practice, e.g. with this recipe:
0. emacs -Q
1. M-x global-display-fill-column-indicator-mode RET
2. M-& ls -la RET ;; or any other command that produces enough lines
3. observe that the global mode is activated in the output buffer
4. M-! ls -la RET
5. the global mode is NOT activated in the output buffer
The difference between these two is that shell-command-on-region uses just
(get-buffer-create "*Shell Command Output*")
and doesn't set its default fundamental-mode explicitly.
The following patch fixes this, but I'm still not sure if we need
to grep all occurrences of get-buffer-create and add set-buffer-major-mode
everywhere?
diff --git a/lisp/simple.el b/lisp/simple.el
index 67ddab3d34..1c4fdf9945 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -3925,6 +3926,7 @@ shell-command-on-region
;; replacing its entire contents.
(let ((buffer (get-buffer-create
(or output-buffer "*Shell Command Output*"))))
+ (set-buffer-major-mode buffer)
(unwind-protect
(if (and (eq buffer (current-buffer))
(or (not shell-command-dont-erase-buffer)
next prev parent reply other threads:[~2019-12-07 22:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 21:53 bug#38111: 27.0.50; globalized-minor-mode not enabled on get-buffer-create Juri Linkov
2019-11-08 9:50 ` Eli Zaretskii
2019-11-12 20:33 ` Juri Linkov
2019-11-12 22:42 ` Phil Sainty
2019-11-13 21:12 ` Juri Linkov
2019-11-15 9:02 ` Eli Zaretskii
2019-12-07 22:56 ` Juri Linkov [this message]
2019-12-08 16:54 ` Eli Zaretskii
2019-12-08 22:27 ` Juri Linkov
2020-09-20 11:06 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fthvhhj3.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=38111@debbugs.gnu.org \
--cc=psainty@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.