From: Bastien <bzg@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: Document backward-incompatible change in ORG-NEWS?
Date: Tue, 25 Feb 2020 20:34:51 +0100 [thread overview]
Message-ID: <87fteyea04.fsf@gnu.org> (raw)
In-Reply-To: <87mu97c9sd.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 25 Feb 2020 10:10:10 +0100")
Hi Nicolas,
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> You are right. This deserves an entry in ORG-NEWS.
thanks for your feedback, I've added this entry:
https://code.orgmode.org/bzg/org-mode/commit/1a84a8b611
> I think this is inefficient. It would be better to search directly for
>
> (format "\\[\\[\\*%s\\s-+" (regexp-opt org-todo-keywords-1 t))
Indeed... I've pushed a simpler version, feel free to enhance it.
>> (setq new (replace-regexp-in-string
>> (concat (regexp-opt org-todo-keywords-1) "\\s-+")
>> "" raw))
>> (set-text-properties 0 (length new) nil new)
>
> Why do you remove all text properties? Also, see `org-no-properties'.
For the record, it seems that completing-read fifth argument cannot
be a string with properties - at least from the quick test I did.
Thanks,
--
Bastien
prev parent reply other threads:[~2020-02-25 19:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 6:38 [BUG] Recently master branch commit breaks open file: link stardiviner
2020-02-24 8:41 ` Bastien
2020-02-24 12:06 ` stardiviner
2020-02-24 12:15 ` Bastien
2020-02-24 15:09 ` stardiviner
2020-02-24 20:30 ` Bastien
2020-02-24 20:35 ` Document backward-incompatible change in ORG-NEWS? (was: [BUG] Recently master branch commit breaks open file: link) Bastien
2020-02-24 21:31 ` Samuel Wales
2020-02-25 7:02 ` stardiviner
2020-02-25 9:10 ` Document backward-incompatible change in ORG-NEWS? Nicolas Goaziou
2020-02-25 19:34 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fteyea04.fsf@gnu.org \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.