From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#18336: 24.4.50; When editing externally changed file, Emacs asks too many questions Date: Sun, 22 Mar 2020 23:26:55 -0400 Message-ID: <87ftdzkayo.fsf@gmail.com> References: <87mwaq74xg.fsf@fencepost.gnu.org> <83sgisypbd.fsf@gnu.org> <87pndwklz6.fsf@fencepost.gnu.org> <83o8tgyn1k.fsf@gnu.org> <874kv83pg7.fsf@fencepost.gnu.org> <83lfokylpp.fsf@gnu.org> <87r1yb8kbv.fsf@gmail.com> <87wo8340ct.fsf@stefankangas.se> <874kv7ozf9.fsf@fencepost.gnu.org> <87o8tf7xu3.fsf@gmail.com> <83mu8yyawu.fsf@gnu.org> <874kv299f7.fsf@gmail.com> <87pndqet7k.fsf@fencepost.gnu.org> <8536amk7q6.fsf@gmail.com> <838skevbsn.fsf@gnu.org> <87y2rtjinc.fsf@gmail.com> <83k13ccvah.fsf@gnu.org> <87r1xkjsvf.fsf@gmail.com> <83d094co4s.fsf@gnu.org> <87o8sojhpi.fsf@gmail.com> <83zhc8b0wx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="18567"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.90 (gnu/linux) Cc: dak@gnu.org, stefan@marxist.se, 18336@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 23 04:28:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jGDl5-0004iV-5b for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Mar 2020 04:28:11 +0100 Original-Received: from localhost ([::1]:56848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGDl4-0007Lg-8D for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Mar 2020 23:28:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52340) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jGDkx-0007LI-HH for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2020 23:28:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jGDkw-0000vU-HL for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2020 23:28:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45355) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jGDkw-0000vP-DA for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2020 23:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jGDkw-0002WQ-Ad for bug-gnu-emacs@gnu.org; Sun, 22 Mar 2020 23:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Mar 2020 03:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18336 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 18336-submit@debbugs.gnu.org id=B18336.15849340259609 (code B ref 18336); Mon, 23 Mar 2020 03:28:02 +0000 Original-Received: (at 18336) by debbugs.gnu.org; 23 Mar 2020 03:27:05 +0000 Original-Received: from localhost ([127.0.0.1]:51328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGDk1-0002Up-5a for submit@debbugs.gnu.org; Sun, 22 Mar 2020 23:27:05 -0400 Original-Received: from mail-qt1-f181.google.com ([209.85.160.181]:32818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jGDjy-0002U5-S5; Sun, 22 Mar 2020 23:27:03 -0400 Original-Received: by mail-qt1-f181.google.com with SMTP id d22so10601670qtn.0; Sun, 22 Mar 2020 20:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=W+1PPGZncAoytLVAPTRId/ONItrCIF28T1PD+KnSZAc=; b=cJGhW4RCoCzEpGNBwD332PPHThT5JunvPL44+Sek5ysui/NREh50W8PNCGJTJPPVMM GvckUAqEMU4pGexGO0KSoyGImvQr58XMays910affRgF0Jc/j0bQn7INqjF+xgQqfyuL LDt+Z8Tx4pv+4R/lqF+OsKuTTls+MIR7b8XpQE5yR07F6wW6T9Ks0akShuAEOuKVKDsV PHJ1CsRsh/Kr7YVkQN9OAhGLlgWRBlMWbYsc+Cx4HHCBjKo63O0lwRLiVGBA+faxhRaq rCSM2F1uwoe7rZ0PjxbEPM5tyjvii3xBqltik4XGUyjlMSW9ynmESYbwoHVDuw21cps3 X/5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=W+1PPGZncAoytLVAPTRId/ONItrCIF28T1PD+KnSZAc=; b=NTJJb7dwHpoGg9T33XkCm1w0W2/PgVD5GXg0HyScd7kWtV/7RqWB4T9NaQyv2GoSG8 Dm9zim+qgLqeAsppcCBEncW+zOi4Xk+CR7HWIp8BYbkzbxTg5q6ojxzXjkP+Se4DP+2U 7vL2tcI3Z8Ipky6wYAfhuxXrxG3i3XZNHjLhS3n9VhYqeJCQCZs81Qm3guCZmU3HZsaZ Zekh++vRHfOibmyDIl8QLs+/w2+B/Gs6P1G/9TDghVSSwN34OOZQ484LDEaFmXnc5kAg mutXRe7TgBgzGbTKcayOuO28HOoldjloChP5GQGUqH2Gd0lEpsmDZla/byg5bVRlSlEb gnEg== X-Gm-Message-State: ANhLgQ1U/ZqDA2Qanlrx1FiBHS7Cr75nw8Y86N/M+U+2x6F/KB4AqEbH lgUSQhKrTk6jqKlEP/iPxuGKwKUt X-Google-Smtp-Source: ADFU+vtRNm4gn8jWWNoz77ti7aK2Q5BIcQoDNtvJngXMFeElMcv71QDrlkNxinr6RQCe1sOqR5pl/w== X-Received: by 2002:aed:21bc:: with SMTP id l57mr19166205qtc.218.1584934017091; Sun, 22 Mar 2020 20:26:57 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id p38sm11442585qtf.50.2020.03.22.20.26.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 22 Mar 2020 20:26:56 -0700 (PDT) In-Reply-To: <83zhc8b0wx.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 Mar 2020 22:16:30 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177642 Archived-At: tags 18336 fixed close 18336 28.1 quit Eli Zaretskii writes: >> From: Noam Postavsky >> Cc: dak@gnu.org, stefan@marxist.se, 18336@debbugs.gnu.org >> Date: Sun, 22 Mar 2020 15:46:33 -0400 >> >> > AFAIU, 'fn' in lock_file is the file we want to lock, not the file we >> > create to indicate the lock. Am I missing something? >> >> Oh, you're right, I was confused. The patch below seems to work. > > LGTM, thanks. Pushed to master. [1: 8f694831c0]: 2020-03-22 23:06:05 -0400 Avoid extra "changed on disk" prompt in save-buffer (Bug#18336) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8f694831c04b1fb9db81be72afdc1a1101d619c4