all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
Cc: Org Mode list <emacs-orgmode@gnu.org>,
	Emacs developers <emacs-devel@gnu.org>
Subject: Re: [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode
Date: Thu, 07 May 2020 12:48:16 +0200	[thread overview]
Message-ID: <87ftcc9g27.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <877dxpazbo.fsf_-_@gmail.com> ("Kévin Le Gouguec"'s message of "Wed, 06 May 2020 16:54:35 +0200")

Hello,

Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:

> Here's a complete patch to make RET and C-j honor electric-indent-mode
> in org-mode, targeting Org's master branch.

Thank you very much.

I fixed a typo and applied your patch.

> +(defmacro org-test-with-minor-mode (mode state &rest body)
> +  "Run BODY after setting MODE to STATE.
> +Restore MODE to its former state afterward."
> +  (declare (debug (sexp sexp body)) (indent 2))
> +  `(let ((old-state ,mode))
> +       (,mode (if ,state 1 0))
> +       ,@body
> +       (,mode (if old-state 1 0))))

This is a nice macro.

However, when I have to reproduce a failing test, I don't even want to
think about the recipe and rather concentrate on the results. Hence,
I expect `should' macro's body to be self-sufficient. Therefore,
I skipped this part of the patch.

Regards,

-- 
Nicolas Goaziou



  reply	other threads:[~2020-05-07 10:48 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26 15:43 Convert some files from outline-mode to org-mode Stefan Kangas
2020-04-26 16:13 ` Clément Pit-Claudel
2020-04-26 18:36   ` Stefan Monnier
2020-04-26 19:52     ` Stefan Kangas
2020-04-26 20:54       ` Stefan Monnier
2020-04-26 22:53         ` Clément Pit-Claudel
2020-04-26 16:16 ` H. Dieter Wilhelm
2020-04-26 17:22 ` Alan Mackenzie
2020-04-26 19:29   ` Stefan Kangas
2020-04-26 21:54   ` Kévin Le Gouguec
2020-04-26 22:09     ` Stefan Monnier
2020-04-26 22:41       ` Drew Adams
2020-04-27  7:20         ` Kévin Le Gouguec
2020-04-27 15:23           ` Drew Adams
2020-04-27 15:31             ` Jean-Christophe Helary
2020-04-27  7:39       ` Kévin Le Gouguec
2020-04-27 14:27         ` Reveal-mode (was: Convert some files from outline-mode to org-mode) Stefan Monnier
2020-04-27 10:23     ` Convert some files from outline-mode to org-mode Alan Mackenzie
2020-04-27 11:45       ` Kévin Le Gouguec
2020-04-27 20:30         ` Juri Linkov
2020-04-27 21:24           ` Drew Adams
2020-04-27 23:05           ` John Yates
2020-04-28  2:51           ` Richard Stallman
2020-05-24  6:23             ` Bastien
2020-04-28 15:12           ` Nicolas Goaziou
2020-04-28 16:41             ` H. Dieter Wilhelm
2020-04-28 17:56               ` Nicolas Goaziou
2020-04-28 19:22                 ` H. Dieter Wilhelm
2020-04-28 23:35             ` Juri Linkov
2020-04-29 10:53               ` Nicolas Goaziou
2020-04-29 11:37                 ` Reconciling org-mode idiosyncrasies with Emacs core (was: Convert some files from outline-mode to org-mode) Kévin Le Gouguec
2020-04-29 12:30                   ` Reconciling org-mode idiosyncrasies with Emacs core Nicolas Goaziou
2020-05-04 10:45                     ` Kévin Le Gouguec
2020-05-04 14:50                       ` Nicolas Goaziou
2020-05-04 16:14                         ` Kévin Le Gouguec
2020-05-06 14:54                           ` [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode (was: Reconciling org-mode idiosyncrasies with Emacs core) Kévin Le Gouguec
2020-05-07 10:48                             ` Nicolas Goaziou [this message]
2020-05-07 12:03                               ` [PATCH] Make RET and C-j obey `electric-indent-mode' in org-mode Kévin Le Gouguec
2020-05-07 12:21                                 ` Nicolas Goaziou
2020-05-07 16:45                                   ` Kévin Le Gouguec
2020-05-07 16:50                                     ` Kévin Le Gouguec
2020-05-07 19:38                                       ` Nicolas Goaziou
2020-05-24  6:25                                         ` Bastien
2020-05-07 13:53                             ` Stefan Monnier
2020-05-07 15:33                               ` Kévin Le Gouguec
2020-05-24  6:23             ` Convert some files from outline-mode to org-mode Bastien
2020-05-24  6:18           ` Bastien
2020-04-27 12:14       ` H. Dieter Wilhelm
2020-05-24  6:13   ` Bastien
2020-04-26 18:40 ` Stefan Monnier
2020-05-24  6:15   ` Bastien
2020-04-27  2:23 ` Richard Stallman
2020-04-27  6:37   ` Michael Albinus
2020-04-27  7:12     ` tomas
2020-04-28  2:49     ` Richard Stallman
2020-04-28  9:40       ` Michael Albinus
2020-04-29  3:30         ` Richard Stallman
2020-05-24  6:16     ` Bastien
2020-04-27  9:59 ` Po Lu
2020-04-27 14:36   ` Stefan Monnier
2020-04-27 14:49     ` Jean-Christophe Helary
2020-04-29  3:27       ` Howard Melman
2020-04-29  3:52         ` Jean-Christophe Helary
2020-04-29 13:54           ` Howard Melman
2020-04-29 14:08             ` Jean-Christophe Helary
2020-04-29 14:17             ` Nicolas Goaziou
2020-04-29 14:52               ` Howard Melman
2020-04-29 14:03         ` Stefan Kangas
2020-04-30 10:25           ` H. Dieter Wilhelm
2020-05-07 21:01           ` Stefan Kangas
2020-05-08 17:50             ` Yuri Khan
2020-05-08 17:55               ` Stefan Kangas
2020-05-24  6:35             ` Bastien
2020-04-29 17:52         ` Alan Mackenzie
2020-04-29 19:19           ` Howard Melman
2020-04-30  2:24         ` Richard Stallman
2020-05-24  6:04 ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftcc9g27.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=kevin.legouguec@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.