From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#39971: 28.0.50; Behavior change in flymake-diagnostic-beg/end Date: Tue, 12 May 2020 20:00:41 +0100 Message-ID: <87ftc5ash2.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="59582"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: 39971@debbugs.gnu.org To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 12 21:01:35 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYa9l-000FPv-Rn for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 May 2020 21:01:33 +0200 Original-Received: from localhost ([::1]:43214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYa9k-0000Zd-I4 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 May 2020 15:01:32 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYa9G-0000ZT-BS for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 15:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44961) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYa9G-0002P0-1J for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 15:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYa9F-0004QK-UV for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 15:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 May 2020 19:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39971 X-GNU-PR-Package: emacs Original-Received: via spool by 39971-submit@debbugs.gnu.org id=B39971.158931005116981 (code B ref 39971); Tue, 12 May 2020 19:01:01 +0000 Original-Received: (at 39971) by debbugs.gnu.org; 12 May 2020 19:00:51 +0000 Original-Received: from localhost ([127.0.0.1]:56507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYa95-0004Po-Av for submit@debbugs.gnu.org; Tue, 12 May 2020 15:00:51 -0400 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:52964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYa94-0004PY-Bc for 39971@debbugs.gnu.org; Tue, 12 May 2020 15:00:50 -0400 Original-Received: by mail-wm1-f54.google.com with SMTP id m24so13686640wml.2 for <39971@debbugs.gnu.org>; Tue, 12 May 2020 12:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=QyPEDqC5HPtQ5C8EdvFJbefFNDVzBpYOKXuI59urgH0=; b=ECQkiMn6VZgyYWMh+bn7tkNpdkm+iIhzxoTLX8c2uo3qSWDiYv29Q8yT6U9olOfQtu 7l5B6eesBxiszMO2CFZurtA5KR3D1nOKixMy4IjmOx8Ht5TZ6+W61D6Nspdiy0foaEqN MpQ1XPp9//7anO2BjDmzW8CzXjr6ooB1IBR34I3IzeGICqAFr3ZY5qVLsofWGXKFugy1 i1Pq1Mbhy5EcUS3HxKAJKvtMinqLDSFc7a2gtGHD0yF86K6W0R1oE6RHg+/1CsW8GXpt iNH7bZb9Ix0Sta0V+YfTVsVJKlhnSn288kyCR4hT74Kfo4DmFSZZvLH8GsOdKfu9syRJ f5pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=QyPEDqC5HPtQ5C8EdvFJbefFNDVzBpYOKXuI59urgH0=; b=pm9xmgfzA9/SHT4yRgDqwFF9VWfLUpKhkD35XSKwqLNWcZhEoqnc/fdhp0Iw08cQ8L KDBu0rXvu/ytZU70hpSgkjR1MXGODeyl+YvvfhWeC5gS4y5rNtrSQFM/UzzFSSoblxFK zmdSRtPO/4KeqgrnWDRz+tMA18AfpR2g94VgbIuAUk4406+FlJ/lLlvk/ntkXewm1S8X 5tsEgNOQCAjsyjM6d2IPDel0jaUtMj1HkgPsK7NtpRtNjzsA3kB6BN8QXSWoQUF50Rgb c5u6VOLzjAj+/TUwtCd432y753o9tlv0Il73Fk7oKxCFoTVkSm5lLZf+YzNVl71LyWJZ RoaQ== X-Gm-Message-State: AGi0PuY8DERAEIxQ0T3/SnnbLId4sIJnEWSHenUkqnlDArLxiHXqadkP UOqFZI6E3ox2buS6hFRH0/hPt7jr86A= X-Google-Smtp-Source: APiQypKnrq9PTM0Kd6GsJHFK/VibrdiVr/OToQNBWy4VCqzRhKTVgZdacsSd553i09Ip/3tuBHuBMg== X-Received: by 2002:a1c:1902:: with SMTP id 2mr16031023wmz.178.1589310043931; Tue, 12 May 2020 12:00:43 -0700 (PDT) Original-Received: from krug ([2001:818:d820:9500:824a:171:15a:2213]) by smtp.gmail.com with ESMTPSA id w15sm7589001wmi.35.2020.05.12.12.00.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 May 2020 12:00:42 -0700 (PDT) In-Reply-To: (Philipp Stephani's message of "Sat, 07 Mar 2020 13:28:55 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180117 Archived-At: Philipp Stephani writes: > This was introduced in commit 5b48dab412c61980bca63a67a5d548d07e56b404. > While the intention of that commit is good, I'm not sure we should make > such a breaking change. Programs relying on that behaviour were broken anyway. Do you have non-synthetic example? But even in Emacs 26.3, the new version of Flymake can be (and usually is) upgradeable with M-x install-package. > Basically, the flymake-diagnostic type no longer behaves like an > ordinary struct. It doesn't have to, and that's good. It means we can hide the implementation. If you can come up with a simple enough doc fix that expresses that flymake-diagnostic-beg/end can only be invoked on diagnostics that have been reported to Flymake, I'll merge it. Also, we can make the error message a bit friendlier to express that fact, so maybe include that in your patch? Jo=C3=A3o