From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Gnus: Indicate undownloaded parts in MIME button Date: Tue, 19 May 2020 15:24:19 +0200 Message-ID: <87ftbwt5vg.fsf@gnu.org> References: <87sgg0feiz.fsf@gnu.org> <87blmkrtg3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="53792"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 19 15:25:02 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jb2Ev-000DrR-RV for ged-emacs-devel@m.gmane-mx.org; Tue, 19 May 2020 15:25:01 +0200 Original-Received: from localhost ([::1]:49034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jb2Eu-0002sK-Tf for ged-emacs-devel@m.gmane-mx.org; Tue, 19 May 2020 09:25:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jb2EI-0001rY-BI for emacs-devel@gnu.org; Tue, 19 May 2020 09:24:22 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:50578) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jb2EI-0007c9-0K; Tue, 19 May 2020 09:24:22 -0400 Original-Received: from auth1-smtp.messagingengine.com ([66.111.4.227]:60405) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1jb2EH-0005he-Ps; Tue, 19 May 2020 09:24:21 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 3876D27C0054; Tue, 19 May 2020 09:24:21 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 19 May 2020 09:24:21 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddtjedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnheptd elieffkeeuffduueeffefhiedtjeeutdeuveegfffgtdejleekheegkeetkeevnecukfhp peelfedrvdefiedrudefledrudejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehthhhorhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgr lhhithihqdekieejfeekjeekgedqieefhedvleekqdhtshguhheppehgnhhurdhorhhgse hfrghsthhmrghilhdrfhhm X-ME-Proxy: Original-Received: from thinkpad-t440p (p5dec8baf.dip0.t-ipconnect.de [93.236.139.175]) by mail.messagingengine.com (Postfix) with ESMTPA id 77AFD3060C1B; Tue, 19 May 2020 09:24:20 -0400 (EDT) Mail-Followup-To: Lars Ingebrigtsen , emacs-devel@gnu.org In-Reply-To: <87blmkrtg3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 19 May 2020 14:38:04 +0200") X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250912 Archived-At: Lars Ingebrigtsen writes: >> Obviously, that was a usage error (I somehow assumed Gnus would >> download the missing parts as soon as I act on them). But that >> there's no indication that a part hasn't been downloaded is still a >> bit annoying. So I propose the following patch which makes the MIME >> buttons of empty parts read like >> >> [ --- image/png (undownloaded, A C to fetch.)] >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > I haven't tried the patch, but it looks good to me. One super-minor > detail: > >> + (when (= 0 gnus-tmp-length) > > Could perhaps be `zerop'? Sure, double-up in readability! :-) In addition to zerop, I've changed the wording to "not downloaded" as it seems "undownloaded" is not really English (except in Germany, I guess). Thanks for having a look, Tassilo