all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: Gnus: Indicate undownloaded parts in MIME button
Date: Tue, 19 May 2020 15:24:19 +0200	[thread overview]
Message-ID: <87ftbwt5vg.fsf@gnu.org> (raw)
In-Reply-To: <87blmkrtg3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 19 May 2020 14:38:04 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> Obviously, that was a usage error (I somehow assumed Gnus would
>> download the missing parts as soon as I act on them).  But that
>> there's no indication that a part hasn't been downloaded is still a
>> bit annoying.  So I propose the following patch which makes the MIME
>> buttons of empty parts read like
>>
>>   [ --- image/png (undownloaded, A C to fetch.)]
>>                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> I haven't tried the patch, but it looks good to me.  One super-minor
> detail:
>
>> +    (when (= 0 gnus-tmp-length)
>
> Could perhaps be `zerop'?

Sure, double-up in readability! :-)

In addition to zerop, I've changed the wording to "not downloaded" as it
seems "undownloaded" is not really English (except in Germany, I guess).

Thanks for having a look,
Tassilo



      reply	other threads:[~2020-05-19 13:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16  8:52 Gnus: Indicate undownloaded parts in MIME button Tassilo Horn
2020-05-19 12:38 ` Lars Ingebrigtsen
2020-05-19 13:24   ` Tassilo Horn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftbwt5vg.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.