From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty Date: Tue, 19 May 2020 14:34:45 +0200 Message-ID: <87ftbwrtlm.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="89109"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41385@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 19 14:35:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jb1So-000N49-Bo for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 May 2020 14:35:18 +0200 Original-Received: from localhost ([::1]:45180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jb1Sn-0005Rf-Bn for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 May 2020 08:35:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jb1SY-0005Pk-Hi for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 08:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37976) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jb1SY-0005MO-6t for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 08:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jb1SY-0007fI-4d for bug-gnu-emacs@gnu.org; Tue, 19 May 2020 08:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 May 2020 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41385 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41385-submit@debbugs.gnu.org id=B41385.158989169929449 (code B ref 41385); Tue, 19 May 2020 12:35:02 +0000 Original-Received: (at 41385) by debbugs.gnu.org; 19 May 2020 12:34:59 +0000 Original-Received: from localhost ([127.0.0.1]:49522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb1SV-0007ev-4R for submit@debbugs.gnu.org; Tue, 19 May 2020 08:34:59 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jb1ST-0007eb-NC for 41385@debbugs.gnu.org; Tue, 19 May 2020 08:34:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=J27z3dECfFNh6egcWo98vwkE9jNNeqE92xaiOhO7lIs=; b=c0DoiHWen6+siQrG4Vjf1iv0Uy elsaU+uaOeqlDDWL33s5QBKc1Y64hoEAINDGVtWXS3knFz5NUtvKcfU5Q6Pgq8w1T4hX20SZf+/pH Cn0wq/s0K0FHh5HoFsWcz9j2pNXHYHjn+Ig5E6Rn+FZQTzzJ5IpJNLct261aZL9BHry4=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jb1SI-0000XJ-Fe; Tue, 19 May 2020 14:34:50 +0200 In-Reply-To: (Stefan Kangas's message of "Mon, 18 May 2020 17:51:06 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180585 Archived-At: Stefan Kangas writes: > Please see the attached patch which fixes a minor annoyance with > eww-list-bookmarks. [...] > - (pop-to-buffer "*eww bookmarks*") > - (eww-bookmark-prepare)) > + (let ((buf (get-buffer-create "*eww bookmarks*")) no-error) > + (unwind-protect > + (progn > + (pop-to-buffer buf) > + (eww-bookmark-prepare) > + (setq no-error t)) > + (when (not no-error) (kill-buffer buf))))) I don't think this is an ideal way to fix this command -- using error handling to do control flow is usually the wrong thing to do, and it makes debugging difficult. What if there's a real bug in eww-bookmark-prepare? Instead eww-list-bookmarks should just do the (eww-read-bookmarks) (unless eww-bookmarks (user-error "No bookmarks are defined")) bit, I think. It might mean rearranging some stuff in eww-next-bookmark etc, though. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no