From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#41808: 28.0.50; Various battery.el improvements Date: Thu, 11 Jun 2020 18:22:22 +0100 Message-ID: <87ftb1frg1.fsf@tcd.ie> References: <87tuzhzjs3.fsf@tcd.ie> <835zbx601o.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="114918"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41808@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 11 19:23:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jjQv0-000Tmz-BD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jun 2020 19:23:10 +0200 Original-Received: from localhost ([::1]:58610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjQuz-0001jN-7Y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jun 2020 13:23:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjQus-0001iG-2I for bug-gnu-emacs@gnu.org; Thu, 11 Jun 2020 13:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54623) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jjQur-000310-OG for bug-gnu-emacs@gnu.org; Thu, 11 Jun 2020 13:23:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jjQur-0002bt-Kq for bug-gnu-emacs@gnu.org; Thu, 11 Jun 2020 13:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jun 2020 17:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41808 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41808-submit@debbugs.gnu.org id=B41808.15918961549999 (code B ref 41808); Thu, 11 Jun 2020 17:23:01 +0000 Original-Received: (at 41808) by debbugs.gnu.org; 11 Jun 2020 17:22:34 +0000 Original-Received: from localhost ([127.0.0.1]:37936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjQuP-0002bC-S0 for submit@debbugs.gnu.org; Thu, 11 Jun 2020 13:22:34 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:44592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jjQuN-0002ay-Kc for 41808@debbugs.gnu.org; Thu, 11 Jun 2020 13:22:32 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id y17so6977164wrn.11 for <41808@debbugs.gnu.org>; Thu, 11 Jun 2020 10:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+nMgOyRt+mJuG7pFv7wX86kMQhhpK4icvItw0ige984=; b=aWdojTkfw1vgKIwbGfCor1hpcqhiaMZi1rEYccZYz9IUNAWwfJy5lslbz6dHWTEJS8 m5zmGTzqWtNrLG9JA2rXs2L6MH5VBozJd/8BZUHFwY+P5/V+uzA5jjynFQtCH7vAg7eT 5sZQORqTDfjzYPEuxDihLaCmjsG5E8Z61a0Em6V4pN3dNxJf5In9RmVV0Xl9WrsezQsk xQf+dadtZgmxZMW8cSNh6BJ6uswimqLdF8ad18Rue96KdkFb76zB0mPFORU0Zb8dYgqM VYjkkuPFgCKrLAi1EN+duSFirjViEgqB9gJio8RodAVpXvFOqwVzcH/tuyEKpNHIdhPH ugLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+nMgOyRt+mJuG7pFv7wX86kMQhhpK4icvItw0ige984=; b=ZmpP4l+inr572y4DGeYc41QwViG76tgaWm8LOrJrRgCQoujwrBf5t08BS72/9bzREI w1grDjU0H0d5ptUUcLYuZ9JWbjtwU9u3mdQEyyKtkQ8x7bR57pfih+9ASgY7u5c64Wvg PY/fXHjIoJQ1owIu7uppX/b9rzm/r5Z6bHc+vlOxumRMRGXpGtw/D3DYwypNkVvJAi/a wsTR1gA3BYBSeQpeuLOUjydCcPgzkXcxgI9S4RbYEGSCMSNLXAwp8JAL6eS8QEQQc0JE a3FGSb3ZfjFXL/dwj/AN/qp2WNxMv/NdX/1wCq+GPZLeIzdPOhQZ5pUXxXPuLLirpcXM Z0lQ== X-Gm-Message-State: AOAM533+LQ3sWKC9+B/2Q2PvTcx8MdNhDye79PpH0KFZSiBiuCCTEo4g 0KdWEtWAuNz+6kIGZiD3YklKzg== X-Google-Smtp-Source: ABdhPJxcSFV7W96drn3yyUoU/oGAuZ36fr/p5q4A4NUaO5SYUrHdFehWRz0EYcXl8/NQp4MIvrrNEw== X-Received: by 2002:a5d:6109:: with SMTP id v9mr10435879wrt.26.1591896144942; Thu, 11 Jun 2020 10:22:24 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:1f68:7ff5:120d:64e]) by smtp.gmail.com with ESMTPSA id b187sm5243037wmd.26.2020.06.11.10.22.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2020 10:22:23 -0700 (PDT) In-Reply-To: <835zbx601o.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 11 Jun 2020 19:26:43 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181863 Archived-At: Eli Zaretskii writes: >> From: "Basil L. Contovounesios" >> Date: Thu, 11 Jun 2020 16:47:40 +0100 >> Cc: mattias engdeg=C3=A5rd >>=20 >> - ((fboundp 'w32-battery-status) >> + ((functionp 'w32-battery-status) >> #'w32-battery-status)) > > Is something wrong with fboundp? I think we have dozens if not > hundreds of such uses of fboundp, so if something's wrong with it, we > had better fixed them all. The only reason I switched to functionp is because battery-status-function is passed to funcall, but now that I think about it again we're only checking whether the definition exists at all here, so I reverted to fboundp. Thanks, --=20 Basil