From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 41808@debbugs.gnu.org
Subject: bug#41808: 28.0.50; Various battery.el improvements
Date: Thu, 11 Jun 2020 18:22:22 +0100 [thread overview]
Message-ID: <87ftb1frg1.fsf@tcd.ie> (raw)
In-Reply-To: <835zbx601o.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 11 Jun 2020 19:26:43 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Date: Thu, 11 Jun 2020 16:47:40 +0100
>> Cc: mattias engdegård <mattiase@acm.org>
>>
>> - ((fboundp 'w32-battery-status)
>> + ((functionp 'w32-battery-status)
>> #'w32-battery-status))
>
> Is something wrong with fboundp? I think we have dozens if not
> hundreds of such uses of fboundp, so if something's wrong with it, we
> had better fixed them all.
The only reason I switched to functionp is because
battery-status-function is passed to funcall, but now that I think about
it again we're only checking whether the definition exists at all here,
so I reverted to fboundp.
Thanks,
--
Basil
next prev parent reply other threads:[~2020-06-11 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 15:47 bug#41808: 28.0.50; Various battery.el improvements Basil L. Contovounesios
2020-06-11 16:26 ` Eli Zaretskii
2020-06-11 17:22 ` Basil L. Contovounesios [this message]
2020-06-18 15:45 ` Basil L. Contovounesios
2020-06-11 16:29 ` Mattias Engdegård
2020-06-11 17:22 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftb1frg1.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=41808@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.