From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Theodor Thornhill Newsgroups: gmane.emacs.bugs Subject: bug#41858: 28.0.50; [PATCH]: Make project-shell use universal argument Date: Mon, 15 Jun 2020 06:50:53 +0000 Message-ID: <87ftaw3jqx.fsf@thornhill.no> References: <87tuzd33i3.fsf@thornhill.no> <874krdclk2.fsf@mail.linkov.net> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_mMRhWh1pneCco3U9AhsbpaHwWO53Ynlf71DOn2uM1TE" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="41967"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41858@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 15 08:52:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkiyp-000ApR-6t for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Jun 2020 08:52:27 +0200 Original-Received: from localhost ([::1]:38080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkiyn-0002yg-Kp for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Jun 2020 02:52:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40190) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkiyQ-0002yV-OT for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 02:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33467) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkiyQ-0007Ey-FX for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 02:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkiyQ-0006wk-EX for bug-gnu-emacs@gnu.org; Mon, 15 Jun 2020 02:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Jun 2020 06:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41858 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41858-submit@debbugs.gnu.org id=B41858.159220387026644 (code B ref 41858); Mon, 15 Jun 2020 06:52:02 +0000 Original-Received: (at 41858) by debbugs.gnu.org; 15 Jun 2020 06:51:10 +0000 Original-Received: from localhost ([127.0.0.1]:45013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkixa-0006vf-IO for submit@debbugs.gnu.org; Mon, 15 Jun 2020 02:51:10 -0400 Original-Received: from mail-40131.protonmail.ch ([185.70.40.131]:33099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkixW-0006v9-Qq for 41858@debbugs.gnu.org; Mon, 15 Jun 2020 02:51:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=protonmail; t=1592203860; bh=HVQSlGJLVmOnOy/MoBeEHl2c1mCRr1H30JhQam7eVys=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=MGyPaq7kLErmRoasUGwSLbW5wTQfIXy0tIkyulQdfjxJ6Ec5lrILePzXCzqW1TvEp AjMilKCLt66XznFNI7CroEPwkWXaL+ZbwDSWMtK+kfg8vKanlhXt8mXcbAohM9rXfC 45MDH3iWNis6Fmu04dz3RMzDcv5hyTtSsr5VC9fPBQXvx7AKjwVrmzVkj+A72nklQv J11LdVDAcjRdOHZjYyJ44nZtLgNpyQb3pLwBhBLTe9k8qdMfb0KJVJCneEFqsQqimn Ezwac6Db41FASkfURIjNUZFKeuaMzdpV02Kdkw8WLAiTbWtq3to1SH1OqSH0v30ree 8Gme86EoBBufw== In-Reply-To: <874krdclk2.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181977 Archived-At: This is a multi-part message in MIME format. --b1_mMRhWh1pneCco3U9AhsbpaHwWO53Ynlf71DOn2uM1TE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, and thanks for looking at the code! "Juri Linkov" writes: [...] > Thanks, it's a nice idea to prepend the project root dir name > to the shell buffer name. Cool! [...] > So eventually I arrived to the following line for the init file: > > (add-hook 'shell-mode-hook 'rename-uniquely) > > that just appends a number to the buffer name, > so your patch won't affect my usage at all, > I'll continue getting new shell buffers every time > after 'M-x project-shell'. > How about we just add this behaviour instead of appending the file-path? so= we get the "" appended to the shell buffer names. Then you can remove t= hat line from init :) > Regarding the C-u argument, I don't know maybe someone might want > to use it. But shouldn't the C-u argument of 'project-shell' be > more compatible with the C-u argument of 'shell' in its behaviour? I kind of agree, though it seems like the original "project-shell" was inte= nded to be used only interactively. I kind of view it as a specialized case= of "shell", maybe as a sort of "shell-dwim" but only for a very limited ca= se. We are always free of course to add a normal shell buffer in root, and = use it non-interactively in code. However, I can add an "&optional buffer" argument to the code and do like i= t's done in "shell". It just seems like it is complicating the behaviour a = little bit. What do you think? In addition, how do I then avoid duplication of code between the interactiv= e call and the default behaviour? Specifically, I am thinking of the 'defau= lt-directory' which is not set. I guess I have to set that twice then? > Another possible point for better consistency between them > is to use 'pop-to-buffer' (like in 'shell') instead of > 'switch-to-buffer-other-window'. Agreed. Done. I've attached another patch for you to look at, with only the easy changes,= awaiting some feedback on the other parts :) Thanks again, Theodor --b1_mMRhWh1pneCco3U9AhsbpaHwWO53Ynlf71DOn2uM1TE Content-Type: text/x-patch; name=project-shell.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=project-shell.patch ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3Byb2plY3QuZWwgYi9saXNwL3Byb2dtb2Rlcy9w cm9qZWN0LmVsCmluZGV4IGYzZGY0NGZhN2IuLjIxODA1OGIxOTUgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3Byb2plY3QuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcHJvamVjdC5lbApAQCAt Njg2LDExICs2ODYsMjAgQEAgcHJvamVjdC12Yy1kaXIKIAogOzs7IyMjYXV0b2xvYWQKIChkZWZ1 biBwcm9qZWN0LXNoZWxsICgpCi0gICJPcGVuIFNoZWxsIGluIHRoZSBjdXJyZW50IHByb2plY3Qu IgorICAiT3BlbiBTaGVsbCBpbiB0aGUgY3VycmVudCBwcm9qZWN0LgorV2l0aCBcXFt1bml2ZXJz YWwtYXJndW1lbnRdIHByZWZpeCwgY3JlYXRlIHN1YnNlcXVlbnQgc2hlbGwgYnVmZmVycword2l0 aCB1bmlxdWlmaWVkIG5hbWVzLiIKICAgKGludGVyYWN0aXZlKQotICAobGV0ICgoZGVmYXVsdC1k aXJlY3RvcnkgKHByb2plY3Qtcm9vdCAocHJvamVjdC1jdXJyZW50IHQpKSkpCi0gICAgOzsgVXNl IOKAmGNyZWF0ZS1maWxlLWJ1ZmZlcuKAmSB0byB1bmlxdWlmeSBzaGVsbCBidWZmZXIgbmFtZXMu Ci0gICAgKHNoZWxsIChjcmVhdGUtZmlsZS1idWZmZXIgIipzaGVsbCoiKSkpKQorICAobGV0KiAo KGRlZmF1bHQtZGlyZWN0b3J5IChwcm9qZWN0LXJvb3QgKHByb2plY3QtY3VycmVudCB0KSkpCisg ICAgICAgICAoZGVmYXVsdC1wcm9qZWN0LXNoZWxsLW5hbWUKKyAgICAgICAgICAgKGNvbmNhdCAi KiIgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkKKyAgICAgICAgICAgICAgICAgICAgICAgIChkaXJl Y3RvcnktZmlsZS1uYW1lCisgICAgICAgICAgICAgICAgICAgICAgICAgKGZpbGUtbmFtZS1kaXJl Y3RvcnkgZGVmYXVsdC1kaXJlY3RvcnkpKSkKKyAgICAgICAgICAgICAgICAgICAiLXNoZWxsKiIp KQorICAgICAgICAgKHNoZWxsLWJ1ZmZlciAoZ2V0LWJ1ZmZlciBkZWZhdWx0LXByb2plY3Qtc2hl bGwtbmFtZSkpKQorICAgIChpZiAoYW5kIHNoZWxsLWJ1ZmZlciAobm90IGN1cnJlbnQtcHJlZml4 LWFyZykpCisgICAgICAgIChwb3AtdG8tYnVmZmVyIHNoZWxsLWJ1ZmZlcikKKyAgICAgIChzaGVs bCAoZ2VuZXJhdGUtbmV3LWJ1ZmZlci1uYW1lIGRlZmF1bHQtcHJvamVjdC1zaGVsbC1uYW1lKSkp KSkKIAogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBwcm9qZWN0LWVzaGVsbCAoKQo= --b1_mMRhWh1pneCco3U9AhsbpaHwWO53Ynlf71DOn2uM1TE--