From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name Date: Sat, 22 Aug 2020 16:41:18 +0200 Message-ID: <87ft8elp4h.fsf@gnus.org> References: <96cafba3-7ba2-4e87-8f9d-e53825fd1dde@default> <94feda5f-7afa-4ab5-96f8-60dfaba7e0a4@default> <469bf659-07b6-8172-287c-2abc53582447@yandex.ru> <83zhoi74vl.fsf@gnu.org> <44b1aa8a-c06c-61f7-0948-0fd20605e938@yandex.ru> <83y34273mu.fsf@gnu.org> <2979c506-20e4-4b9f-0215-6f0241238678@yandex.ru> <83v9z6732b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20866"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 35353@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 22 16:42:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9Uif-0005JW-Ig for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Aug 2020 16:42:09 +0200 Original-Received: from localhost ([::1]:43906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9Uie-0005xt-3v for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Aug 2020 10:42:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60626) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9UiY-0005xk-LM for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2020 10:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k9UiY-0004aG-CK for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2020 10:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k9UiY-0004ES-8J for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2020 10:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Aug 2020 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35353 X-GNU-PR-Package: emacs Original-Received: via spool by 35353-submit@debbugs.gnu.org id=B35353.159810730116242 (code B ref 35353); Sat, 22 Aug 2020 14:42:02 +0000 Original-Received: (at 35353) by debbugs.gnu.org; 22 Aug 2020 14:41:41 +0000 Original-Received: from localhost ([127.0.0.1]:50950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9UiD-0004Du-Jv for submit@debbugs.gnu.org; Sat, 22 Aug 2020 10:41:41 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:36532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9Ui9-0004DZ-HS for 35353@debbugs.gnu.org; Sat, 22 Aug 2020 10:41:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4GqXJ28BsxIoLuAlgvp/aXY22lU8K8a8X75Ui+FSj9U=; b=U+c4z0aRmZcK0qGfiKPsPQ8DmH oQiFQ87zUH7kGieYQFCwa7S2ZOHEopjFItkBMbJ9Zc5trZi2Ocogl/+fGmmgIB4culyUrFilNB9Mu 3XEly6HM9gj358AiG/kGnWIxzCNZyvAs1tvbV6oNVauLt8IfAq2h3rl4uTx8xzSuFxo4=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9Uhs-00007K-Av; Sat, 22 Aug 2020 16:41:31 +0200 X-Now-Playing: Nettle's _El Resplandor: The Shining in Dubai_: "Espina" In-Reply-To: (Dmitry Gutov's message of "Mon, 22 Apr 2019 13:52:17 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185954 Archived-At: Dmitry Gutov writes: > The fix is not hard, though. Is the variable more targeted on other > use cases? Or is it just obscure enough for us not to bother? > > The patch looks like this (to be accompanied with an appropriate renaming): [...] > - (define-key map [mouse-1] #'xref-goto-xref) > - (define-key map [mouse-2] #'xref--mouse-2) > + (define-key map [follow-link] 'mouse-face) > + (define-key map [mouse-2] #'xref-goto-xref) > + (define-key map [mouse-1] #'xref--mouse-2) I think that this is basically what most modes that have clickable stuff do, so I think it might be the right solution for xref, too (even if xref doesn't have buttons per se). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no