From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id iIukCxS2U1/CDAAA0tVLHw (envelope-from ) for ; Sat, 05 Sep 2020 16:00:20 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id ABB6BxS2U19aGAAAB5/wlQ (envelope-from ) for ; Sat, 05 Sep 2020 16:00:20 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9CF1F9400D3 for ; Sat, 5 Sep 2020 16:00:19 +0000 (UTC) Received: from localhost ([::1]:49874 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEaby-0001LE-6i for larch@yhetil.org; Sat, 05 Sep 2020 12:00:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEabS-0001Kx-Iq for emacs-orgmode@gnu.org; Sat, 05 Sep 2020 11:59:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35583) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEabS-0007p1-9T; Sat, 05 Sep 2020 11:59:46 -0400 Received: from [2a01:e35:2fe1:f780:68c6:8f4c:dae1:2381] (port=41420 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1kEabR-00020L-4F; Sat, 05 Sep 2020 11:59:45 -0400 Received: by guerry (Postfix, from userid 1000) id EE7DC1A60D69; Sat, 5 Sep 2020 17:59:42 +0200 (CEST) From: Bastien To: No Wayman Subject: Re: [PATCH] org-add-planning-info: respect caller's given time [9.3.7 (release_9.3.7-716-g3d4876 @ /home/n/.emacs.d/straight/build/org/)] Organization: GNU References: <87zh6rfvmi.fsf@gmail.com> Date: Sat, 05 Sep 2020 17:59:42 +0200 In-Reply-To: <87zh6rfvmi.fsf@gmail.com> (No Wayman's message of "Tue, 18 Aug 2020 18:16:05 -0400") Message-ID: <87ft7wdxjl.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: R4J4dWaj4FXA Hi, No Wayman writes: > The current behavior of `org-add-planning-info' does not include the > time of day when > it is passed the TIME argument. This is because `org-time-was-given' > is initially let-bound to nil > during the scope of the function. > > The attached patch removes that binding and allows the caller to pass > the time of day in the above case. Applied in maint as c7abcd514, thanks. -- Bastien