From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Thu, 10 Dec 2020 09:57:46 +0200 Message-ID: <87ft4edret.fsf@protesilaos.com> References: <87im9fgm27.fsf@protesilaos.com> <87zh2ozer4.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17099"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 45068@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 10 08:58:46 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1knGqc-0004Ky-2p for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Dec 2020 08:58:46 +0100 Original-Received: from localhost ([::1]:60008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knGqb-0007FU-5w for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Dec 2020 02:58:45 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knGpu-0006ze-0p for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2020 02:58:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53611) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knGpt-0004K4-QO for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2020 02:58:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knGpt-0001uH-PO for bug-gnu-emacs@gnu.org; Thu, 10 Dec 2020 02:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Dec 2020 07:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.16075870787317 (code B ref 45068); Thu, 10 Dec 2020 07:58:01 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 10 Dec 2020 07:57:58 +0000 Original-Received: from localhost ([127.0.0.1]:36924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knGpq-0001tx-As for submit@debbugs.gnu.org; Thu, 10 Dec 2020 02:57:58 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:46055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knGpn-0001tg-Ru for 45068@debbugs.gnu.org; Thu, 10 Dec 2020 02:57:56 -0500 X-Originating-IP: 94.46.225.161 Original-Received: from kronos (unknown [94.46.225.161]) (Authenticated sender: public@protesilaos.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 65835FF802; Thu, 10 Dec 2020 07:57:47 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Wed, 9 Dec 2020 15:58:40 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195619 Archived-At: On 2020-12-09, 15:58 -0600, Stefan Kangas wrote: > "Basil L. Contovounesios" writes: > >>> Those are the issues I could identify. As such, the attached patch >>> removes the old files and places the new ones in ../lisp/modus-themes/. >>> The themes' manual is updated to cover the new version. The NEWS entry >>> is edited accordingly. >>> >>> I understand you may object to the course of action covered by the >>> patch. Please inform me of a better way to address this issue. My >>> intent is to contribute version 1.0 of my themes to Emacs (1.0.2 to be >>> precise) and am prepared to make the requisite changes based on your >>> feedback. >> >> FWIW, I'd sooner make the infrastructure changes needed to make themes >> under etc/themes/ more modular and package-like, than start moving them >> out of etc/themes/. >> >> Otherwise, I'd expect themes under lisp/ to behave exactly like those >> under etc/themes/, which would make the etc/themes/ directory redundant. >> (Maybe we need a lisp/themes/ directory?) > > Yes, I think if we start adding a number of these themes under > "lisp/-theme/" it risks getting messy over time. > > Would it make sense to just add a "lisp/themes" directory, as Basil > suggests, containing the new files modus-themes-core.el and > modus-themes.el? > > That way, I assume that we can just keep the themes in "etc/themes" for > now, while any theme that needs it can put its support libraries in > "lisp/themes". Does that make sense? Would it work without any changes > to load-theme? Thank you Stefan and Basil! I agree that putting them all under lisp/ is not the right way to go right now. Today I will experiment with placing the libraries in lisp/themes and the derivatives in etc/themes. This will obfuscate the source code though, but I will try nonetheless and report back to you (without prejudice to any other ideas you or someone else may have). -- Protesilaos Stavrou protesilaos.com